Introduce nRF7120 SoC and board definitions to sdk-nrf #20070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
github-actions
bot
added
the
changelog-entry-required
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: f73fc0b2162cc2b7bacea2e9af4e8d9ac3b7a3ee more detailssdk-nrf:
Github labels
List of changed files detected by CI (38)Outputs:ToolchainVersion: 342151af73 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
nordicjm
reviewed
Jan 24, 2025
| series: | ||
| - name: nrf71 | ||
| socs: | ||
| - name: nrf7120_enga |
There was a problem hiding this comment.
Suggested change
| - name: nrf7120_enga | |
| - name: nrf7120 |
The board can select the revision'd Kconfig but there is only one SoC
|
also shouldn't be e.g. noup in sdk-nrf commit titles, that is for sdk-* OSS repos only |
rob-robinson-14
force-pushed
the
NRFX-6596-add-nrf7120-soc-board-definitions
branch
2 times, most recently
from
b6ae797 to
338f9ac
Compare
ioannisg
reviewed
Jan 27, 2025
rob-robinson-14
force-pushed
the
NRFX-6596-add-nrf7120-soc-board-definitions
branch
from
338f9ac to
58c71c8
Compare
nordicjm
requested changes
Jan 27, 2025
Comment on lines
+8
to
+12
| config NRF_MPC_REGION_SIZE | ||
| hex | ||
| default 0x1000 | ||
| help | ||
| Region size for the Memory Protection Controller (MPC) in bytes. |
Comment on lines
+14
to
+32
| config NRF_TRUSTZONE_FLASH_REGION_SIZE | ||
| hex | ||
| default NRF_MPC_REGION_SIZE | ||
| help | ||
| This defines the flash region size from the TRUSTZONE perspective. | ||
| It is used when configuring the TRUSTZONE and when setting alignments | ||
| requirements for the partitions. | ||
| This abstraction allows us to configure TRUSTZONE without depending | ||
| on peripheral specific symbols. | ||
|
|
||
| config NRF_TRUSTZONE_RAM_REGION_SIZE | ||
| hex | ||
| default NRF_MPC_REGION_SIZE | ||
| help | ||
| This defines the RAM region size from the TRUSTZONE perspective. | ||
| It is used when configuring the TRUSTZONE and when setting alignments | ||
| requirements for the partitions. | ||
| This abstraction allows us to configure TRUSTZONE without depending | ||
| on peripheral specific symbols. |
There was a problem hiding this comment.
there are not anything to do with a board
rob-robinson-14
force-pushed
the
NRFX-6596-add-nrf7120-soc-board-definitions
branch
from
58c71c8 to
d1e423f
Compare
rob-robinson-14
force-pushed
the
NRFX-6596-add-nrf7120-soc-board-definitions
branch
from
d1e423f to
501616d
Compare
Add dts files for nRF7120 Signed-off-by: David Jewsbury <[email protected]> Co-authored-by: Robert Robinson <[email protected]>
Add nRF7120 to soc directory Signed-off-by: Robert Robinson <[email protected]> Co-authored-by: David Jewsbury <[email protected]>
Add board files for nRF7120pdk Signed-off-by: David Jewsbury <[email protected]> Co-authored-by: Robert Robinson <[email protected]>
This adds the nrf7120pdk/cpuapp/ns board variant to sdk-zephyr. It allows to build nrf7120pdk with TF-M in nRF Connect SDK. This is done as a noup as the out-of-tree board extension feature is not available. When zephyrproject-rtos/zephyr#69548 is completed this commit can be reverted and the variant be placed in sdk-nrf. Signed-off-by: Robert Robinson <[email protected]>
The SoftDevice Controller is a different controller than the open source link layer with a different set of quirks. It should therefore have its own device tree binding. This commit converts the SoftDevice Controller driver to use this new DTS binding instead of reusing the existing one. This commit updates or adds additional overlays for existing samples, applications and tests that were using the open source link layer. Signed-off-by: Robert Robinson <[email protected]>
nRF7120 has been added to soc folder in NCS, therefore, soc_root needs to be added to module.yml Signed-off-by: David Jewsbury <[email protected]>
The license agreement for files within sdk-nrf differs from what will eventually be required from upstream zephyr. All SPDX-License-Identifier: Apache-2.0 have been updated to SPDX-License-Identifier: LicenseRef-Nordic-5-Clause Signed-off-by: Robert Robinson <[email protected]>
rob-robinson-14
force-pushed
the
NRFX-6596-add-nrf7120-soc-board-definitions
branch
from
501616d to
f73fc0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR containing out of tree definitions for nrf7120.