samples: Fix printing welcome message example->sample #19889

grochu · 2025-01-14T10:02:24Z

Align with the NCS naming.

test_ble_samples: fix_naming_sample

NordicBuilder · 2025-01-14T10:05:45Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 71935d90ca61df2502090bf99c4d02af4ea0d314

more details

sdk-nrf:

PR head: 71935d90ca61df2502090bf99c4d02af4ea0d314
merge base: 020cc3fe3ac6adc8f2a26972768a8a594b19a8c4
target head (main): 588b082f9144f84fffd5f91c47186f26e596d2c0
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (50)

samples
│  ├── bluetooth
│  │  ├── central_and_peripheral_hr
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── central_bas
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── central_hids
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── central_hr_coded
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── central_nfc_pairing
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── central_smp_client
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── central_uart
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── direct_test_mode
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── event_trigger
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── fast_pair
│  │  │  ├── input_device
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── locator_tag
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  ├── llpm
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── multiple_adv_sets
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── nrf_dm
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_ams_client
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_ancs_client
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_bms
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_cgms
│  │  │  ├── prj.conf
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_cts_client
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_gatt_dm
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_hids_keyboard
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_hids_mouse
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_hr_coded
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_lbs
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_mds
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_nfc_pairing
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_power_profiling
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_rscs
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_status
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── peripheral_uart
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── rpc_host
│  │  │  │ README.rst
│  │  ├── shell_bt_nus
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── subrating
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── throughput
│  │  │  ├── README.rst
│  │  │  ├── src
│  │  │  │  │ main.c
│  ├── nfc
│  │  ├── record_launch_app
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── record_text
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── shell
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── tag_reader
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── writable_ndef_msg
│  │  │  ├── src
│  │  │  │  │ main.c
│  ├── peripheral
│  │  ├── radio_test
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 7
✅ Integration tests
- ✅ test-fw-nrfconnect-ble_samples
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi

Note: This message is automatically posted and updated by the CI

kapi-no

HIDS samples looking good. Could you also align our two Fast Pair samples?

nrf/samples/bluetooth/fast_pair/input_device/src/main.c
nrf/samples/bluetooth/fast_pair/locator_tag/src/main.c

maje-emb

Shouldn't we also update the documentation? e.g. for peripheral_uart sample.

grochu · 2025-01-14T12:27:44Z

Shouldn't we also update the documentation? e.g. for peripheral_uart sample.

Good point, I'll update the docs too.

grochu · 2025-01-14T13:27:42Z

Updated documentation as @maje-emb suggests.

NordicBuilder · 2025-01-14T13:42:39Z

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

divipillai · 2025-01-14T13:42:18Z

samples/bluetooth/peripheral_uart/README.rst

@@ -247,7 +247,7 @@ After programming the sample to your development kit, complete the following ste
      #. Reset the kit.
      #. Observe that **LED 0** is blinking and the device is advertising under the default name **Nordic_UART_Service**.
         You can configure this name using the :kconfig:option:`CONFIG_BT_DEVICE_NAME` Kconfig option.
-      #. Observe that the text "Starting Nordic UART service example" is printed on the COM listener running on the computer.
+      #. Observe that the text "Starting Nordic UART service sample" is printed on the COM listener running on the computer.


Here: https://docs.nordicsemi.com/bundle/ncs-latest/page/nrf/samples/bluetooth/rpc_host/README.html#testing,
Shouldn't the Testing section of the rpc_host sample also updated with "sample" instead of example.

After programming the example build to your ........

Good catch! I missed that even though I run a search to Bluetooth samples.

Yeah, this also needs update!

Align code and documentation with the NCS naming. Ref. NCSDK-30029 Signed-off-by: Michał Grochala <[email protected]>

rlubos · 2025-01-21T13:31:31Z

@nrfconnect/ncs-dragoon @nrfconnect/ncs-dragoon-doc Ping, please review.

grochu requested review from a team and leewkb4567 as code owners January 14, 2025 10:02

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 14, 2025

grochu requested a review from greg-fer January 14, 2025 10:02

dchat-nordic approved these changes Jan 14, 2025

View reviewed changes

leewkb4567 approved these changes Jan 14, 2025

View reviewed changes

kapi-no approved these changes Jan 14, 2025

View reviewed changes

grochu force-pushed the fix_printk_samples branch from 7fafdac to 08b02a5 Compare January 14, 2025 10:33

maje-emb requested changes Jan 14, 2025

View reviewed changes

grochu force-pushed the fix_printk_samples branch from 08b02a5 to d07dce9 Compare January 14, 2025 13:24

grochu requested review from a team as code owners January 14, 2025 13:24

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Jan 14, 2025

grochu requested a review from peknis January 14, 2025 13:31

peknis approved these changes Jan 14, 2025

View reviewed changes

divipillai reviewed Jan 14, 2025

View reviewed changes

maje-emb approved these changes Jan 15, 2025

View reviewed changes

grochu force-pushed the fix_printk_samples branch from d07dce9 to 822fd13 Compare January 16, 2025 13:04

divipillai approved these changes Jan 16, 2025

View reviewed changes

samples: Fix printing welcome message example->sample

71935d9

Align code and documentation with the NCS naming. Ref. NCSDK-30029 Signed-off-by: Michał Grochala <[email protected]>

grochu force-pushed the fix_printk_samples branch from 822fd13 to 71935d9 Compare January 16, 2025 15:15

richabp approved these changes Jan 21, 2025

View reviewed changes

hermabe approved these changes Jan 21, 2025

View reviewed changes

rlubos merged commit 188c9aa into nrfconnect:main Jan 21, 2025
13 checks passed

grochu deleted the fix_printk_samples branch January 27, 2025 12:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: Fix printing welcome message example->sample #19889

samples: Fix printing welcome message example->sample #19889

grochu commented Jan 14, 2025 •

edited

Loading

NordicBuilder commented Jan 14, 2025 •

edited

Loading

kapi-no left a comment

maje-emb left a comment

grochu commented Jan 14, 2025

grochu commented Jan 14, 2025

NordicBuilder commented Jan 14, 2025

divipillai Jan 14, 2025

peknis Jan 14, 2025

grochu Jan 14, 2025

grochu Jan 16, 2025

rlubos commented Jan 21, 2025

samples: Fix printing welcome message example->sample #19889

samples: Fix printing welcome message example->sample #19889

Conversation

grochu commented Jan 14, 2025 • edited Loading

NordicBuilder commented Jan 14, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

kapi-no left a comment

Choose a reason for hiding this comment

maje-emb left a comment

Choose a reason for hiding this comment

grochu commented Jan 14, 2025

grochu commented Jan 14, 2025

NordicBuilder commented Jan 14, 2025

divipillai Jan 14, 2025

Choose a reason for hiding this comment

peknis Jan 14, 2025

Choose a reason for hiding this comment

grochu Jan 14, 2025

Choose a reason for hiding this comment

grochu Jan 16, 2025

Choose a reason for hiding this comment

rlubos commented Jan 21, 2025

grochu commented Jan 14, 2025 •

edited

Loading

NordicBuilder commented Jan 14, 2025 •

edited

Loading