Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: nrf_modem_lib: Use debug logs of expected errnos on backend write #19820

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lib: nrf_modem_lib: Use debug logs of expected errnos on backend write #19820

wants to merge 1 commit into from

Conversation

eivindj-nordic
Copy link
Contributor

We use -ENOSPC and -ENOSPC to signal from the backend that there is no space in backend or it is not properly connected. This can occur from time to time and is not always an error. Though, it can be noisy in log output. This commit replaces the error logs with debug level and adds a hint that the backend should be properly connected.

@eivindj-nordic eivindj-nordic self-assigned this Jan 9, 2025
@eivindj-nordic eivindj-nordic requested review from a team as code owners January 9, 2025 12:50
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2025
@eivindj-nordic
Copy link
Contributor Author

I don't think we need a changelog entry for changing this log level, @divipillai?

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 9, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: fa125401484c7c046ac66e2477733d5529074d67

more details

sdk-nrf:

PR head: fa125401484c7c046ac66e2477733d5529074d67
merge base: 5ae88098dfb7279a30f153eb9b7f06ff691ba60c
target head (main): f38d3119502c014935538628b3305009dd0697ff
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1) 
lib
│  ├── nrf_modem_lib
│  │  │ nrf_modem_lib_trace.c

Outputs:

Toolchain

Version: 11349092be
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:11349092be_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 446
  • ❌ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ❌ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
    • ⚠️ test-fw-nrfconnect-nrf-iot_lwm2m
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@eivindj-nordic eivindj-nordic force-pushed the modem_trace_less_noisy branch from b8a9edf to 5439000 Compare January 9, 2025 12:54
@divipillai
Copy link
Contributor

I don't think we need a changelog entry for changing this log level, @divipillai?

Agree, as from the description seems like an intermittent issue.

@eivindj-nordic eivindj-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 9, 2025
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

MirkoCovizzi
MirkoCovizzi reviewed Jan 9, 2025
View reviewed changes
lib/nrf_modem_lib/nrf_modem_lib_trace.c Outdated
LOG_ERR("trace_backend.write failed with err: %d", ret);
} else {
LOG_DBG("trace_backend.write returned with %d", ret);
LOG_DBG("Is the backend properly connected?");
Copy link
Contributor

@MirkoCovizzi MirkoCovizzi Jan 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to pose this as a statement rather than a question? Perhaps outline possible scenarios or solutions and make it more explicit and actionable.
For example:
Please make sure that the backend is properly connected. or something like that.
This fits more with the rest of the logs in NCS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, updated.

@eivindj-nordic
lib: nrf_modem_lib: Use debug logs of expected errnos on backend write
fa12540 
We use -ENOSPC and -ENOSPC to signal from the backend that there
is no space in backend or it is not properly connected. This can
occur from time to time and is not always an error. Though, it can
be noisy in log output. This commit replaces the error logs with
debug level and adds a hint that the backend should be properly
connected.

Signed-off-by: Eivind Jølsgard <[email protected]>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 14, 2025
@eivindj-nordic eivindj-nordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MirkoCovizzi MirkoCovizzi MirkoCovizzi left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@eivindj-nordic eivindj-nordic

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@eivindj-nordic @NordicBuilder @divipillai @MirkoCovizzi