Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nrf_security: drivers: cracen: adding support for ed25519 without sicrypto #19812
base: main
Are you sure you want to change the base?
nrf_security: drivers: cracen: adding support for ed25519 without sicrypto #19812
Changes from all commits
1bc05ae
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 66 in subsys/nrf_security/src/drivers/cracen/cracenpsa/src/ed25519.c
GitHub Actions / Run compliance checks on patch series (PR)
STATIC_CONST_CHAR_ARRAY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Check warning on line 75 in subsys/nrf_security/src/drivers/cracen/cracenpsa/src/ed25519.c
GitHub Actions / Run compliance checks on patch series (PR)
STATIC_CONST_CHAR_ARRAY
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment would rather be for the implementation of
ed25519_calculate_r()
I think?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am sorry, maybe I am blind, but is this comment not before
ed25519_calculate_r
. Or do you mean I should move it inside the function itself?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same further down, booleans to say yes/no rather than integers.