suit: in-place updateable components #19760

SylwesterKonczyk · 2025-01-07T09:41:05Z

Extension of SUIT in-place updateable component module. Support for an access to IPUC from IPC client added.

Ref: NCSDK-30808

NordicBuilder · 2025-01-07T09:44:15Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 29

Inputs:

Sources:

sdk-nrf: PR head: 616e493e7718bb70e2d6806d2ab604b36a3bf82f

more details

sdk-nrf:

PR head: 616e493e7718bb70e2d6806d2ab604b36a3bf82f
merge base: f26a3904094961c09ad0901f681eb6644c7e3948
target head (main): 48253248ecc493e0c3fed104f8ff090d5a55964d
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (40)

subsys
│  ├── sdfw_services
│  │  ├── services
│  │  │  ├── suit_service
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── suit_ipuc.c
│  │  │  │  ├── suit_service.cddl
│  │  │  │  ├── zcbor_generated
│  │  │  │  │  ├── suit_service_decode.c
│  │  │  │  │  ├── suit_service_decode.h
│  │  │  │  │  ├── suit_service_encode.c
│  │  │  │  │  ├── suit_service_encode.h
│  │  │  │  │  │ suit_service_types.h
│  ├── suit
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── ipuc
│  │  │  ├── CMakeLists.txt
│  │  │  ├── Kconfig
│  │  │  ├── include
│  │  │  │  ├── suit_ipuc.h
│  │  │  │  │ suit_ipuc_sdfw.h
│  │  │  ├── src
│  │  │  │  │ suit_ipuc_sdfw.c
│  │  ├── platform
│  │  │  ├── CMakeLists.txt
│  │  │  ├── include
│  │  │  │  │ suit_plat_ipuc.h
│  │  │  ├── sdfw
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── Kconfig
│  │  │  │  ├── src
│  │  │  │  │  ├── suit_plat_copy_sdfw_specific.c
│  │  │  │  │  ├── suit_plat_ipuc.c
│  │  │  │  │  │ suit_plat_write_sdfw_specific.c
│  │  │  ├── src
│  │  │  │  ├── suit_plat_components.c
│  │  │  │  │ suit_plat_fetch.c
tests
│  ├── subsys
│  │  ├── suit
│  │  │  ├── copy
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── fetch
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── ipuc
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  ├── unit
│  │  │  │  ├── mocks
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── include
│  │  │  │  │  │  ├── mock_suit_ipuc_sdfw.h
│  │  │  │  │  │  ├── mock_suit_plat_ipuc.h
│  │  │  │  │  │  │ mocks.h
│  │  │  │  ├── suit_plat_override_image_size
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  ├── write
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── src
│  │  │  │  │  │ main.c

Outputs:

Toolchain

Version: 11349092be
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:11349092be_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 145
🟠 Integration tests
- 🟠 test-sdk-dfu
- ⚠️ test-sdk-dfu

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2025-01-09T13:36:31Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

adsz-nordic

Few minor findings

subsys/suit/ipuc/Kconfig

subsys/suit/ipuc/src/suit_ipuc_sdfw.c

subsys/suit/platform/src/suit_plat_components.c

subsys/suit/ipuc/Kconfig

subsys/suit/ipuc/src/suit_ipuc_sdfw.c

subsys/suit/ipuc/CMakeLists.txt

ahasztag

In a couple of places related to memory reading and writing, it seems that very "advanced" tools are used, while much simpler ones are necessary.

subsys/suit/ipuc/src/suit_ipuc_sdfw.c

subsys/suit/ipuc/Kconfig

nordicjm · 2025-01-13T14:41:39Z

subsys/sdfw_services/services/suit_service/suit_ipuc.c

+	*role = rsp_data->SSF_SUIT_RSP_ARG(get_ipuc_info, role);
+	ssf_client_decode_done(rsp_pkt);
+
+#if (defined CONFIG_SUIT_LOG_LEVEL_INF || defined CONFIG_SUIT_LOG_LEVEL_DBG)


Suggested change

#if (defined CONFIG_SUIT_LOG_LEVEL_INF || defined CONFIG_SUIT_LOG_LEVEL_DBG)

#if defined(CONFIG_SUIT_LOG_LEVEL_INF) || defined(CONFIG_SUIT_LOG_LEVEL_DBG)

Apply bracket changes throughout whole PR

nordicjm · 2025-01-13T14:42:04Z

tests/subsys/suit/unit/mocks/CMakeLists.txt

@@ -93,7 +93,8 @@ endif()

 if (CONFIG_MOCK_SUIT_IPUC)


should not be a space here (fix in a later cleanup PR)

when time comes

Extension of SUIT in-place updateable component module. Support for an access to IPUC from IPC client added. Ref: NCSDK-30808 Signed-off-by: Sylwester Konczyk <[email protected]>

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 7, 2025

SylwesterKonczyk force-pushed the ipuc branch 10 times, most recently from 6bfc33c to dc2b027 Compare January 9, 2025 13:19

SylwesterKonczyk force-pushed the ipuc branch 2 times, most recently from f47894d to 3ffeeca Compare January 9, 2025 15:10

SylwesterKonczyk marked this pull request as ready for review January 10, 2025 04:31

SylwesterKonczyk requested review from a team as code owners January 10, 2025 04:31

adsz-nordic approved these changes Jan 10, 2025

View reviewed changes

tomchy reviewed Jan 10, 2025

View reviewed changes

subsys/suit/platform/src/suit_plat_components.c Show resolved Hide resolved

subsys/suit/ipuc/Kconfig Outdated Show resolved Hide resolved

subsys/suit/ipuc/src/suit_ipuc_sdfw.c Outdated Show resolved Hide resolved

tomchy reviewed Jan 10, 2025

View reviewed changes

subsys/suit/ipuc/CMakeLists.txt Show resolved Hide resolved

SylwesterKonczyk force-pushed the ipuc branch from 3ffeeca to f474d4c Compare January 13, 2025 05:32

SylwesterKonczyk requested a review from tomchy January 13, 2025 05:36

ahasztag requested review from ahasztag, adsz-nordic and nordic-mik7 January 13, 2025 07:22

ahasztag requested changes Jan 13, 2025

View reviewed changes

SylwesterKonczyk force-pushed the ipuc branch from f474d4c to 71c6335 Compare January 13, 2025 09:38

SylwesterKonczyk requested a review from ahasztag January 13, 2025 10:12

ahasztag approved these changes Jan 13, 2025

View reviewed changes

tomchy approved these changes Jan 13, 2025

View reviewed changes

SylwesterKonczyk force-pushed the ipuc branch from 71c6335 to 1711f34 Compare January 13, 2025 14:20

nordicjm reviewed Jan 13, 2025

View reviewed changes

SylwesterKonczyk force-pushed the ipuc branch from 1711f34 to bb5dbbd Compare January 13, 2025 15:16

SylwesterKonczyk requested a review from nordicjm January 13, 2025 15:23

adsz-nordic approved these changes Jan 14, 2025

View reviewed changes

SylwesterKonczyk force-pushed the ipuc branch from bb5dbbd to 88c77d7 Compare January 14, 2025 08:43

suit: in-place updateable components

616e493

Extension of SUIT in-place updateable component module. Support for an access to IPUC from IPC client added. Ref: NCSDK-30808 Signed-off-by: Sylwester Konczyk <[email protected]>

SylwesterKonczyk force-pushed the ipuc branch from 88c77d7 to 616e493 Compare January 14, 2025 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

suit: in-place updateable components #19760

suit: in-place updateable components #19760

SylwesterKonczyk commented Jan 7, 2025

NordicBuilder commented Jan 7, 2025 •

edited

Loading

NordicBuilder commented Jan 9, 2025

adsz-nordic left a comment

ahasztag left a comment

nordicjm Jan 13, 2025

SylwesterKonczyk Jan 13, 2025

nordicjm Jan 13, 2025

SylwesterKonczyk Jan 13, 2025

	#if (defined CONFIG_SUIT_LOG_LEVEL_INF \|\| defined CONFIG_SUIT_LOG_LEVEL_DBG)
	#if defined(CONFIG_SUIT_LOG_LEVEL_INF) \|\| defined(CONFIG_SUIT_LOG_LEVEL_DBG)

suit: in-place updateable components #19760

Are you sure you want to change the base?

suit: in-place updateable components #19760

Conversation

SylwesterKonczyk commented Jan 7, 2025

NordicBuilder commented Jan 7, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Jan 9, 2025

adsz-nordic left a comment

Choose a reason for hiding this comment

ahasztag left a comment

Choose a reason for hiding this comment

nordicjm Jan 13, 2025

Choose a reason for hiding this comment

SylwesterKonczyk Jan 13, 2025

Choose a reason for hiding this comment

nordicjm Jan 13, 2025

Choose a reason for hiding this comment

SylwesterKonczyk Jan 13, 2025

Choose a reason for hiding this comment

NordicBuilder commented Jan 7, 2025 •

edited

Loading