Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correction of errors in voltage calculation #17491

Open
wants to merge 1 commit into
base: v2.7-branch
Choose a base branch
from
Open

Correction of errors in voltage calculation #17491

wants to merge 1 commit into from

Conversation

Andrew55529
Copy link

In official documentation on st 25r3911 when we measure voltage, one LSB represents 23.438 mV. When calculating, we multiply the fractional part by a three-digit number. When restoring, we divide it by 100, not by 1000. This is an error.

@Andrew55529 Andrew55529 requested a review from grochu as a code owner September 26, 2024 01:24
@CLAassistant
Copy link

CLAassistant commented Sep 26, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Sep 26, 2024
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Sep 26, 2024
@github-actions GitHub Actions
Copy link

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Nov 10, 2024
@github-actions github-actions bot closed this Nov 28, 2024
@Andrew55529 Andrew55529 mentioned this pull request Jan 23, 2025
Open
@grochu grochu reopened this Jan 23, 2025
@Andrew55529
Copy link
Author

@grochu Renamed

@grochu
Copy link
Contributor

grochu commented Jan 24, 2025

Please add the "Signed-off-by" line and include your full name and email address. As well keep all lines in the message less or equal to 72 characters.

@Andrew55529
lib: st25r3911b: Correction of errors in voltage calculation
45c6eac 
In official documentation on st 25r3911 when we measure voltage,
one LSB represents 23.438 mV.
When calculating, we multiply the fractional part by a
three-digit number. When restoring, we divide it by 100, not by 1000.
This is an error.

Signed-off-by: Andrei Lashkov <[email protected]>
@github-actions github-actions bot removed the Stale label Jan 25, 2025
@Andrew55529
Copy link
Author

Why its failed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grochu grochu Awaiting requested review from grochu grochu is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. external External contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Andrew55529 @CLAassistant @NordicBuilder @grochu