Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing ai pull #280

Draft
wants to merge 4 commits into
base: testingAI
Choose a base branch
from
Draft

Testing ai pull #280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
047b3b7
next
jaci-nordic Jan 9, 2025
06ef1a9
pull request with changes to test AI
jaci-nordic Jan 9, 2025
0ffb530
next
jaci-nordic Jan 9, 2025
4ef8e6f
testing ai
jaci-nordic Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/compliance.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ on: pull_request

jobs:
compliance_job:
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The runs-on value should be a valid version of Ubuntu. ubuntu-24.04 does not exist; consider using ubuntu-22.04 or another supported version.

name: Run compliance checks on patch series (PR)
steps:
- name: Update PATH for west
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/contribs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ on:

jobs:
contribs:
runs-on: ubuntu-22.04
runs-on: ubuntu-latest
name: Contribs
steps:
- name: Contribs
Expand Down
3 changes: 2 additions & 1 deletion .github/workflows/create-upmerge-PRs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,14 @@
run: |
pip3 install -r nrf/scripts/requirements-base.txt
pip3 install -r nrf/scripts/requirements-extra.txt
pip3 inst -r nrf/scripts/requirements-extra.txt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the command: pip3 inst should be corrected to pip3 install.


- name: Get repo urls
working-directory: ncs
run: |
echo "SDK_ZEPHYR=$(west list zephyr -f {url} | awk -F// '{print $NF}')" >> $GITHUB_ENV
echo "SDK_MCUBOOT=$(west list mcuboot -f {url} | awk -F// '{print $NF}')" >> $GITHUB_ENV

#dummy comment

Check failure on line 37 in .github/workflows/create-upmerge-PRs.yml

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

TRAILING_WHITESPACE 

.github/workflows/create-upmerge-PRs.yml:37  trailing whitespace

Check warning on line 37 in .github/workflows/create-upmerge-PRs.yml

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

YAMLLint (comments) 

.github/workflows/create-upmerge-PRs.yml:37 missing starting space in comment

Check warning on line 37 in .github/workflows/create-upmerge-PRs.yml

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

YAMLLint (trailing-spaces) 

.github/workflows/create-upmerge-PRs.yml:37 trailing spaces
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the dummy comment as it does not provide any useful information.

- name: Try closing existing auto-upmerge PRs
run: |
SDK_ZEPHYR_PR=$(gh pr list --repo $SDK_ZEPHYR --label "auto-upmerge" --json number --jq .[0].number)
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/openai.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,9 @@ jobs:
uses: actions/checkout@v3

- name: AI Code Reviewer
uses: your-username/ai-code-reviewer@main
uses: aidar-freeed/ai-codereviewer@main
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # The GITHUB_TOKEN is there by default so you just need to keep it like it is and not necessarily need to add it as secret as it will throw an error. [More Details](https://docs.github.com/en/actions/security-guides/automatic-token-authentication#about-the-github_token-secret)
OPENAI_API_KEY: ${{ secrets.OPENAI_API_KEY }}
OPENAI_API_MODEL: "gpt-4" # Optional: defaults to "gpt-4"
OPENAI_API_MODEL: "gpt-4-turbo" # Optional: defaults to "gpt-4"
#exclude: "**/*.json, **/*.md" # Optional: exclude patterns separated by commas
1 change: 1 addition & 0 deletions samples/app_event_manager_profiler_tracer/sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,5 @@ tests:
- nrf52840dk/nrf52840
- nrf9160dk/nrf9160/ns
- nrf21540dk/nrf52840
- nrf3u9348934/someNewBoard
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The addition of - nrf3u9348934/someNewBoard seems arbitrary. Ensure that this entry is necessary and follows the naming conventions used for other boards.

tags: ci_build sysbuild ci_samples_app_event_manager_profiler_tracer
2 changes: 1 addition & 1 deletion samples/event_manager_proxy/common_events/control_event.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#include "control_event.h"


static void profile_control_event(struct log_event_buf *buf,
static int profile_control_event(struct log_event_buf *buf,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the return type from void to int requires handling the return value appropriately. Ensure that all calls to profile_control_event are updated to handle the new return type.

const struct app_event_header *aeh)
{
}
Expand Down
3 changes: 2 additions & 1 deletion samples/suit/recovery/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
The SUIT recovery application is a minimal application that allows recovering the device firmware if the original firmware is damaged.
It is to be used as a companion firmware to the main application that is using :ref:`Software Update for Internet of Things (SUIT) <ug_nrf54h20_suit_intro>` procedure, rather than a stand-alone application.

The following limitations apply to this application:
The following limitations apply to this aptikation:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the word 'aptikation'; it should be 'application'.

The following limitations apply to this aplication:

Check warning on line 14 in samples/suit/recovery/README.rst

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

TYPO_SPELLING 

samples/suit/recovery/README.rst:14  'aplication' may be misspelled - perhaps 'application'?
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in the word 'aplication'; it should be 'application'.


* The recovery firmware is only able to recover from a situation where the application or radio core are damaged.
It does not recover from Nordic Semiconductor-controlled firmware failures.
Expand Down
2 changes: 1 addition & 1 deletion samples/suit/recovery/prj.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ CONFIG_SUIT_RECOVERY=y
# The MPI has to be generated from the top level application, not from
# the recovery application. This is because the digests of the main application MPI
# and the recovery application MPI is calculated together for a given domain.
CONFIG_SUIT_MPI_GENERATE=n
CONFIG_SUIT_MPI_GENERATE=nonono
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The value for CONFIG_SUIT_MPI_GENERATE should be either y or n. Using nonono is invalid and could lead to configuration errors.

CONFIG_SUIT_ENVELOPE_OUTPUT_MPI_MERGE=n

# It is the main application which is responsible for flashing and generating the UICR
Expand Down
2 changes: 1 addition & 1 deletion scripts/bluetooth/mesh/mesh_dfu_metadata.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,8 +156,8 @@
kconfig, value = line.split("=", 1)
configs[kconfig] = value.strip()
return configs
except Exception as err :

Check warning on line 159 in scripts/bluetooth/mesh/mesh_dfu_metadata.py

View workflow job for this annotation

GitHub Actions / Run compliance checks on patch series (PR)

W0612 

scripts/bluetooth/mesh/mesh_dfu_metadata.py:159 Unused variable 'err' (unused-variable)
raise Exception("Unable to parse .config file") from err
raise Exception("Unable to parse .config file")
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The from keyword in the exception raising is useful for preserving the original traceback. Consider keeping it to aid in debugging.


def version_parse(self):
try:
Expand Down
Loading