Allow Zigbee Rejoin Timeout to be configured via Kconfig #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edmont
approved these changes
Jan 14, 2025
kendallgoto
force-pushed
the
kgoto/configurable-timeout
branch
from
47e28a2 to
05ec787
Compare
Signed-off-by: Kendall Goto <[email protected]>
kendallgoto
force-pushed
the
kgoto/configurable-timeout
branch
from
05ec787 to
7da7276
Compare
|
sure @edmont ! ready now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found it to be useful to adjust the value of
ZB_DEV_REJOIN_TIMEOUT_MSdepending on the device type / network coordinator to improve device resilience e.g. at long distances or during power failures. We believe it makes sense for this timeout to be configurable via Kconfig, rather than hidden away inzigbee_app_utils.csince device developers should be aware of situations where the end device may disconnect and fail to rejoin until manually interacted with, if this timeout is breached.It was previously overridable with an
#ifndefguard, but it is not clear how developers are expected to overwrite this definition without modifying the SDK or manually adding the build flag. Moving it to Kconfig seems to be much more straight forward for an option that is likely important to device developers.