refactor(hitl): pass playwright context to web interaction

npi-ai · Jan 26, 2025 · 5cc479a · 5cc479a
1 parent 75d8449
commit 5cc479a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 0 deletions.
diff --git a/npiai/core/__test__/captcha_detection.py b/npiai/core/__test__/captcha_detection.py
@@ -2,6 +2,7 @@
 from typing import Literal
 
 from npiai import BrowserTool, HITL
+from npiai.core import PlaywrightContext
 from npiai.utils.test_utils import DebugContext
 
 
@@ -40,6 +41,7 @@ async def web_interaction(
         message: str,
         url: str,
         action: Literal["captcha", "login"],
+        playwright: PlaywrightContext,
     ) -> str:
         print(f"[HITL] web_interaction: {message=}, {url=}, {action=}")
         return "web_interaction"

diff --git a/npiai/core/hitl.py b/npiai/core/hitl.py
@@ -2,6 +2,7 @@
 from typing import List, Literal
 
 from npiai.context import Context
+from npiai.core import PlaywrightContext
 
 
 class HITL(ABC):
@@ -42,4 +43,5 @@ async def web_interaction(
         message: str,
         url: str,
         action: Literal["captcha", "login"],
+        playwright: PlaywrightContext,
     ) -> str: ...
diff --git a/npiai/core/tool/_browser.py b/npiai/core/tool/_browser.py
@@ -306,13 +306,15 @@ async def handle_captcha(captcha_type: Literal["none", "captcha", "login"]):
                         message="Would you please help me solve the captcha?",
                         url=url,
                         action="captcha",
+                        playwright=self.playwright,
                     )
                 case "login":
                     await ctx.hitl.web_interaction(
                         tool_name=self.name,
                         message="Would you please help me login to the website?",
                         url=url,
                         action="login",
+                        playwright=self.playwright,
                     )
 
             return captcha_type

diff --git a/npiai/tools/scrapers/web/__test__/interactive.py b/npiai/tools/scrapers/web/__test__/interactive.py
@@ -1,6 +1,7 @@
 import asyncio
 from typing import Literal
 
+from npiai.core import PlaywrightContext
 from npiai.utils.test_utils import DebugContext
 
 # from npiai import Context
@@ -44,6 +45,7 @@ async def web_interaction(
         message: str,
         url: str,
         action: Literal["captcha", "login"],
+        playwright: PlaywrightContext,
     ) -> str:
         print(f"[HITL] web_interaction: {message=}, {url=}, {action=}")
         return "web_interaction"