fix: cleaned off middleware bloat (#83)

.github/workflows/go.yml

@@ -19,20 +19,9 @@ jobs:
       - uses: actions/checkout@v3
 
       - name: Set up Go
-        uses: actions/setup-go@v2
+        uses: actions/setup-go@v4
         with:
-          go-version: 1.21
-
-      - name: Restore cache
-        uses: actions/cache@v3
-        with:
-          path: |
-            ~/go/pkg/mod
-            ~/.cache/go-build
-            vendor
-          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
-          restore-keys: |
-            ${{ runner.os }}-go-
+          go-version: 1.22.x
 
       - name: Build and test
         run: |

go.mod

@@ -1,6 +1,6 @@
 module github.com/noxecane/anansi
 
-go 1.21
+go 1.22
 
 require (
 	github.com/go-chi/chi/v5 v5.0.10

webpack/webpack.go

@@ -28,7 +28,7 @@ type WebpackOpts struct {
 //
 // - Automatic Request IDs
 //
-// - Response time middleware(and metrics if a registry is passed)
+// - Response time middleware and header(and metrics if a registry is passed)
 //
 // - Real IP middleware
 //
@@ -40,8 +40,6 @@ type WebpackOpts struct {
 //
 // - Request Logging
 //
-// - Response time header
-//
 // - Panic Recovery(with special support for api.Error)
 //
 // - Timeouts on request context
@@ -75,11 +73,25 @@ func Webpack(router *chi.Mux, log zerolog.Logger, conf WebpackOpts) {
 	router.Use(api.Recoverer(conf.Environment))
 }
 
+// HTMLPack sets a reasonable set of middleware in the right order taking into consideration
+// those that defer computation(especially)
+//
+// The middleware set up includes:
+//
+// - Automatic Request IDs
+//
+// - Real IP middleware
+//
+// - Compressing response body
+//
+// - Request Logging
+//
+// - Response time header
+//
+// - Panic Recovery(with special support for api.Error)
+//
+// - Timeouts on request context
 func HTMLpack(router *chi.Mux, log zerolog.Logger, conf WebpackOpts) {
-	if len(conf.CORSOrigins) > 0 {
-		requests.CORS(conf.Environment, conf.CORSOrigins...)
-	}
-
 	if conf.CompressionLevel == 0 {
 		conf.CompressionLevel = 5
 	}
@@ -97,8 +109,5 @@ func HTMLpack(router *chi.Mux, log zerolog.Logger, conf WebpackOpts) {
 	router.Use(requests.Timeout(conf.Timeout))
 
 	router.Use(responses.ResponseTime)
-	if conf.Registry != nil {
-		router.Use(responses.RequestDuration(conf.Registry))
-	}
 	router.Use(api.Recoverer(conf.Environment))
 }