Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Squad Score #68 #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Squad Score #68 #70

wants to merge 1 commit into from

Conversation

kailashchoudhary11
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Oct 8, 2022

@kailashchoudhary11 is attempting to deploy a commit to the Novu Team on Vercel.

A member of the Team first needs to authorize it.

@kailashchoudhary11
Copy link
Author

@nevo-david Please Review!

bsantosh909
bsantosh909 reviewed Oct 11, 2022
View reviewed changes
Copy link
Collaborator

@bsantosh909 bsantosh909 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, not sure if that is the best place for us to display the score though.

@nevo-david
Copy link
Contributor

It's nice but I think it's better to show the squad position

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsantosh909 bsantosh909 bsantosh909 left review comments

@nevo-david nevo-david Awaiting requested review from nevo-david

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kailashchoudhary11 @nevo-david @bsantosh909