Build workflow updates #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scopsy
changed the title
scopsy
reviewed
Nov 25, 2024
mint.json
Outdated
| "integrations/providers/push/pushpad", | ||
| "integrations/providers/push/push-webhook", | ||
| "integrations/providers/push/pusher-beams" | ||
| "workflow/channels/sms", |
There was a problem hiding this comment.
Seems like you changed all the urls for those pages, it will affect SEO. We will need to have redirects to them. But, I don't think the delivery providers should live under workflow, would keep it as parallel concept
workflow/overview.mdx
Outdated
Comment on lines
78
to
80
| - Delay | ||
| - Digest | ||
| - Custom |
There was a problem hiding this comment.
Let's add here links and in any other relevant place
workflow/overview.mdx
Outdated
|
|
||
| ### Trigger | ||
|
|
||
| Every workflow starts with a **trigger**. This is the event that starts a workflow. It represents an action or event that initiates the workflow by making a call to the Novu API, along with a specified workflow trigger identifier (`workflow_id`). The identifier helps match the trigger to the corresponding workflow. |
There was a problem hiding this comment.
The first 2 sentences feel almost identical, maybe rephrase it?
workflow/overview.mdx
Outdated
|
|
||
| Every workflow starts with a **trigger**. This is the event that starts a workflow. It represents an action or event that initiates the workflow by making a call to the Novu API, along with a specified workflow trigger identifier (`workflow_id`). The identifier helps match the trigger to the corresponding workflow. | ||
|
|
||
| When a trigger occurs, it sends the necessary payload data that the workflow will use to deliver notifications to subscribers. **Learn more about subscribers**. |
workflow/overview.mdx
Outdated
| Here's an example of an API call to trigger an event: | ||
|
|
||
| ```bash | ||
| curl -X POST https://api.novu.co/v2/events/trigger \ |
There was a problem hiding this comment.
There is no v2 events endpoint to my knowledge
workflow/overview.mdx
Outdated
| "subscriberId": "<UNIQUE_SUBSCRIBER_IDENTIFIER>", | ||
| }, | ||
| "payload": {} | ||
| } |
There was a problem hiding this comment.
I think this one is extra "}"
workflow/step-conditions.mdx
Outdated
| sidebarTitle: "Step Conditions" | ||
| --- | ||
|
|
||
| **Step Conditions** allow you to customize a **Subscriber's** workflow journey using their **Data**, **Topics**, **Segment Membership**, or prior behavior. |
There was a problem hiding this comment.
What a segment membership is? we don't have any concept like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-11-25.at.1.53.20.mov
After the initial review, I will modify and add the rest.