remove background push and fix push response handling #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,17 +33,25 @@ public override async void DidReceiveNotificationRequest(UNNotificationRequest r | |||
| //Save the notification and create a mutable copy | |||
| BestAttemptContent = (UNMutableNotificationContent)request.Content.MutableCopy(); | |||
There was a problem hiding this comment.
Somehow the formatting is really fucked up here with tabs and spaces.
| @@ -51,22 +51,10 @@ public static INotifoMobilePush UseFirebasePluginEventsProvider(this INotifoMobi | |||
| /// <param name="notifo">The <see cref="INotifoMobilePush"/> instance.</param> | |||
| /// <param name="data">The notification data dictionary.</param> | |||
| /// <returns>A <see cref="Task"/> representing the result of the asynchronous operation.</returns> | |||
| public static async Task DidReceiveMessageAsync(this INotifoMobilePush notifo, NSDictionary data) | |||
| public static void DidReceiveMessageAsync(this INotifoMobilePush notifo, NSDictionary data) | |||
There was a problem hiding this comment.
Should not be called "Async", if it is not async.
| { | ||
| options ??= new PullRefreshOptions(); | ||
| var options = new PullRefreshOptions(); |
There was a problem hiding this comment.
This makes the full options useless.
There was a problem hiding this comment.
yeah that's right. Could be removed completely but what do you think in general of removing the pullRefresh?
There was a problem hiding this comment.
In general I tried not to have some non-configurable values, but it is weird, that these options are configured over the method. So we should just add a method to INotifoPush like
NotifoPush.Current.SetPullOptions(...);
There was a problem hiding this comment.
I have introduced this change in the base branch
SebastianStehle
force-pushed
the
master
branch
from
640549a to
cc77f79
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.