Version 3.2.3

Fixed: `Notiflix.Block.*`: The custom class name option was not being set correctly. The temporary position class name for the reference element was not being removed if it was being used with a custom class name. [#45](#45)
notiflix · Jan 29, 2022 · 2a8f920 · 2a8f920
1 parent 79c6f27
commit 2a8f920
Show file tree

Hide file tree

Showing 28 changed files with 146 additions and 88 deletions.
diff --git a/.eslintrc.js → .dev/.eslintrc.js b/.eslintrc.js → .dev/.eslintrc.js
@@ -1,3 +1,5 @@
+// For TypeScript
+
 module.exports = {
   overrides: [{
     files: ['*.d.ts', '*.ts', '*.tsx'],
@@ -38,9 +40,9 @@ module.exports = {
         'single',
         {
           'avoidEscape': true,
-          'allowTemplateLiterals': true
-        }
-      ]
+          'allowTemplateLiterals': true,
+        },
+      ],
     },
   }],
-}
+};
diff --git a/.dev/.eslintrc.json b/.dev/.eslintrc.json
@@ -0,0 +1,43 @@
+{
+  "env": {
+    "browser": true,
+    "commonjs": true,
+    "es6": true,
+    "node": true
+  },
+  "extends": "eslint:recommended",
+  "globals": {
+    "Atomics": "readonly",
+    "SharedArrayBuffer": "readonly"
+  },
+  "parserOptions": {
+    "ecmaVersion": 2021
+  },
+  "rules": {
+    "comma-dangle": [
+      "error",
+      "always-multiline"
+    ],
+    "semi": [
+      "error",
+      "always"
+    ],
+    "indent": [
+      "error",
+      2,
+      {
+        "ignoredNodes": [
+          "TemplateLiteral"
+        ]
+      }
+    ],
+    "quotes": [
+      2,
+      "single",
+      {
+        "avoidEscape": true,
+        "allowTemplateLiterals": true
+      }
+    ]
+  }
+}
diff --git a/.dev/notiflix-dev-builder.js b/.dev/notiflix-dev-builder.js
@@ -5,7 +5,7 @@
 *
 * Version: 1.0.0
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix - All In One, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix - All In One, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 'use-strict';

diff --git a/.dev/notiflix-dev-constants.js b/.dev/notiflix-dev-constants.js
@@ -4,7 +4,7 @@
 * Description: Notiflix constants for the development.
 * Version: 1.0.0
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix - Constants, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix - Constants, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 // Dev Dependencies
@@ -68,7 +68,7 @@ module.exports = {
   version: (JSON.stringify((package || {}).version) || '').replace(/"/gm, ''),
   author: (JSON.stringify((package || {}).author) || '').replace(/"/gm, ''),
   license: 'MIT Licence (https://opensource.org/licenses/MIT)',
-  year: '2019 - ' + (new Date().getFullYear() || '2021'),
+  year: '2019 - ' + (new Date().getFullYear() || '2022'),
   directories: {
     dist: 'dist',
     build: 'build',

diff --git a/.dev/notiflix-dev-minifier.js b/.dev/notiflix-dev-minifier.js
@@ -5,7 +5,7 @@
 *
 * Version: 1.0.0
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix Minifier, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix Minifier, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 'use-strict';

diff --git a/.eslintrc.json b/.eslintrc.json
@@ -11,7 +11,7 @@
     "SharedArrayBuffer": "readonly"
   },
   "parserOptions": {
-    "ecmaVersion": 11
+    "ecmaVersion": 5
   },
   "rules": {
     "comma-dangle": [
@@ -24,12 +24,7 @@
     ],
     "indent": [
       "error",
-      2,
-      {
-        "ignoredNodes": [
-          "TemplateLiteral"
-        ]
-      }
+      2
     ],
     "quotes": [
       2,

diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,9 @@
+@3.2.3
+* **Fixed:** `Notiflix.Block.*`: The custom class name option was not being set correctly. The temporary position class name for the reference element was not being removed if it was being used with a custom class name.
+  - Fixes => [#45](https://github.com/notiflix/Notiflix/issues/45)
+
+---
+
 @3.2.2
 * **Fixed:** `Notiflix.Confirm.prompt()`: Input `maxlength` attribute value should not be directly related to the default answer length.
   - Fixes => [#43](https://github.com/notiflix/Notiflix/issues/43)

diff --git a/LICENSE b/LICENSE
@@ -1,6 +1,6 @@
 MIT License
 
-Copyright (c) 2019 - 2021 Notiflix
+Copyright (c) 2019 - 2022 Notiflix
 
 Permission is hereby granted, free of charge, to any person obtaining a copy
 of this software and associated documentation files (the "Software"), to deal

diff --git a/README.md b/README.md
@@ -9,8 +9,6 @@
 
 [npm-version-badge]: https://img.shields.io/npm/v/notiflix.svg
 [npm-version-url]: https://www.npmjs.com/package/notiflix
-[dep-badge]: https://david-dm.org/notiflix/Notiflix.svg
-[dep-url]: https://david-dm.org/notiflix/Notiflix.svg
 [synk-badge]: https://snyk.io/test/github/notiflix/Notiflix/badge.svg?targetFile=package.json
 [synk-url]: https://snyk.io/test/github/notiflix/Notiflix?targetFile=package.json
 [typescript-badge]: https://badgen.net/badge/icon/Typed?icon=typescript&label&labelColor=3178c6&color=555
@@ -19,12 +17,11 @@
 [downloads-url]: https://npmjs.org/package/notiflix
 [jsdelivr-badge]: https://data.jsdelivr.com/v1/package/npm/notiflix/badge?style=rounded
 [jsdelivr-url]: https://www.jsdelivr.com/package/npm/notiflix
-[size-badge]: https://img.badgesize.io/https://cdn.jsdelivr.net/npm/[email protected].2/dist/notiflix-aio-3.2.2.min.js?compression=gzip
-[size-url]: https://cdn.jsdelivr.net/npm/[email protected].2/dist/notiflix-aio-3.2.2.min.js
+[size-badge]: https://img.badgesize.io/https://cdn.jsdelivr.net/npm/[email protected].3/dist/notiflix-aio-3.2.3.min.js?compression=gzip
+[size-url]: https://cdn.jsdelivr.net/npm/[email protected].3/dist/notiflix-aio-3.2.3.min.js
 [lic-badge]: https://img.shields.io/github/license/notiflix/Notiflix.svg
 [lic-url]: https://github.com/notiflix/Notiflix/blob/main/LICENSE
 
-<!-- [![Dependencies][dep-badge]][dep-url] -->
 [![npm version][npm-version-badge]][npm-version-url]
 [![Known Vulnerabilities][synk-badge]][synk-url]
 [![TypeScript][typescript-badge]][typescript-url]
@@ -39,7 +36,7 @@ Notiflix is a JavaScript library for client-side non-blocking notifications, pop
 
 ### Current Version
 
-3.2.2 [*](https://github.com/notiflix/Notiflix/blob/main/CHANGELOG.md "CHANGELOG")
+3.2.3 [*](https://github.com/notiflix/Notiflix/blob/main/CHANGELOG.md "CHANGELOG")
 
 ### Browser Compatibility
 
@@ -100,27 +97,27 @@ import { Block } from 'notiflix/build/notiflix-block-aio';
 
 #### CSS and JS
 ```html
-<link rel="stylesheet" href="dist/notiflix-3.2.2.min.css" />
+<link rel="stylesheet" href="dist/notiflix-3.2.3.min.css" />
 
-<script src="dist/notiflix-3.2.2.min.js"></script>
+<script src="dist/notiflix-3.2.3.min.js"></script>
 ```
 
 #### or only JS (All in One - Internal CSS)
 ```html
-<script src="dist/notiflix-aio-3.2.2.min.js"></script>
+<script src="dist/notiflix-aio-3.2.3.min.js"></script>
 ```
 
 #### or only Modules JS (All in One - Internal CSS)
 ```html
-<script src="dist/notiflix-notify-aio-3.2.2.min.js"></script>
+<script src="dist/notiflix-notify-aio-3.2.3.min.js"></script>
 
-<script src="dist/notiflix-report-aio-3.2.2.min.js"></script>
+<script src="dist/notiflix-report-aio-3.2.3.min.js"></script>
 
-<script src="dist/notiflix-confirm-aio-3.2.2.min.js"></script>
+<script src="dist/notiflix-confirm-aio-3.2.3.min.js"></script>
 
-<script src="dist/notiflix-loading-aio-3.2.2.min.js"></script>
+<script src="dist/notiflix-loading-aio-3.2.3.min.js"></script>
 
-<script src="dist/notiflix-block-aio-3.2.2.min.js"></script>
+<script src="dist/notiflix-block-aio-3.2.3.min.js"></script>
 ```
 
 ---------
@@ -772,7 +769,7 @@ Notiflix.Block.init({
 ---------
 
 ### Copyright
-Copyright &copy; 2019 - 2021 Notiflix
+Copyright &copy; 2019 - 2022 Notiflix
 
 ### License
 MIT license - https://opensource.org/licenses/MIT
diff --git a/build/notiflix-aio.js b/build/notiflix-aio.js
@@ -1,9 +1,9 @@
 /*
 * Notiflix AIO (https://notiflix.github.io)
 * Description: This file has been created automatically that using "notiflix.js", and "notiflix.css" files.
-* Version: 3.2.2
+* Version: 3.2.3
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 /* global define */
@@ -1631,7 +1631,7 @@
             blockCreateOrRemoveCounter++;
             var notiflixBlockWrap = window.document.createElement('div');
             notiflixBlockWrap.id = blockSettings.ID + '-' + blockCreateOrRemoveCounter;
-            notiflixBlockWrap.className = blockClassName + '-wrap' + (newBlockSettings.cssAnimation ? ' nx-with-animation' : '');
+            notiflixBlockWrap.className = blockClassName + (newBlockSettings.cssAnimation ? ' nx-with-animation' : '');
             notiflixBlockWrap.style.position = newBlockSettings.position;
             notiflixBlockWrap.style.zIndex = newBlockSettings.zindex;
             notiflixBlockWrap.style.background = newBlockSettings.backgroundColor;
@@ -1760,10 +1760,10 @@
       // Step 2A => Remove each block element: end
 
       // Step 2B => Remove each element's class name: begin
-      var removeEachElementClassName = function (eachElement) {
+      var removeEachElementClassName = function (eachElement, className) {
+        var positionClass = className + '-position';
         var timeout = setTimeout(function () {
           // remove class name
-          var positionClass = blockClassName + '-position';
           eachElement.classList.remove(positionClass);
 
           // clear timeout
@@ -1778,7 +1778,7 @@
           var eachElement = allHTMLElements[i];
           if (eachElement) {
             // remove each element's class name
-            removeEachElementClassName(eachElement);
+            removeEachElementClassName(eachElement, blockClassName);
 
             // remove each block element
             eachBlockElement = eachElement.querySelectorAll('[id^=' + blockSettings.ID + ']');
@@ -1792,7 +1792,10 @@
     }
 
     // extend new settings with the backup settings
-    newBlockSettings = commonExtendOptions(true, newBlockSettings, newBlockSettingsBackup);
+    var reverseSettingsTimeout = setTimeout(function () {
+      newBlockSettings = commonExtendOptions(true, newBlockSettings, newBlockSettingsBackup);
+      clearTimeout(reverseSettingsTimeout);
+    }, (delay || 0));
   };
   // BLOCK: Create or Remove: end
 

diff --git a/build/notiflix-block-aio.js b/build/notiflix-block-aio.js
@@ -1,9 +1,9 @@
 /*
 * Notiflix Block AIO (https://notiflix.github.io)
 * Description: This file has been created automatically that using "notiflix.js", and "notiflix.css" files.
-* Version: 3.2.2
+* Version: 3.2.3
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 /* global define */
@@ -345,7 +345,7 @@
             blockCreateOrRemoveCounter++;
             var notiflixBlockWrap = window.document.createElement('div');
             notiflixBlockWrap.id = blockSettings.ID + '-' + blockCreateOrRemoveCounter;
-            notiflixBlockWrap.className = blockClassName + '-wrap' + (newBlockSettings.cssAnimation ? ' nx-with-animation' : '');
+            notiflixBlockWrap.className = blockClassName + (newBlockSettings.cssAnimation ? ' nx-with-animation' : '');
             notiflixBlockWrap.style.position = newBlockSettings.position;
             notiflixBlockWrap.style.zIndex = newBlockSettings.zindex;
             notiflixBlockWrap.style.background = newBlockSettings.backgroundColor;
@@ -474,10 +474,10 @@
       // Step 2A => Remove each block element: end
 
       // Step 2B => Remove each element's class name: begin
-      var removeEachElementClassName = function (eachElement) {
+      var removeEachElementClassName = function (eachElement, className) {
+        var positionClass = className + '-position';
         var timeout = setTimeout(function () {
           // remove class name
-          var positionClass = blockClassName + '-position';
           eachElement.classList.remove(positionClass);
 
           // clear timeout
@@ -492,7 +492,7 @@
           var eachElement = allHTMLElements[i];
           if (eachElement) {
             // remove each element's class name
-            removeEachElementClassName(eachElement);
+            removeEachElementClassName(eachElement, blockClassName);
 
             // remove each block element
             eachBlockElement = eachElement.querySelectorAll('[id^=' + blockSettings.ID + ']');
@@ -506,7 +506,10 @@
     }
 
     // extend new settings with the backup settings
-    newBlockSettings = commonExtendOptions(true, newBlockSettings, newBlockSettingsBackup);
+    var reverseSettingsTimeout = setTimeout(function () {
+      newBlockSettings = commonExtendOptions(true, newBlockSettings, newBlockSettingsBackup);
+      clearTimeout(reverseSettingsTimeout);
+    }, (delay || 0));
   };
   // BLOCK: Create or Remove: end
 

diff --git a/build/notiflix-confirm-aio.js b/build/notiflix-confirm-aio.js
@@ -1,9 +1,9 @@
 /*
 * Notiflix Confirm AIO (https://notiflix.github.io)
 * Description: This file has been created automatically that using "notiflix.js", and "notiflix.css" files.
-* Version: 3.2.2
+* Version: 3.2.3
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 /* global define */

diff --git a/build/notiflix-loading-aio.js b/build/notiflix-loading-aio.js
@@ -1,9 +1,9 @@
 /*
 * Notiflix Loading AIO (https://notiflix.github.io)
 * Description: This file has been created automatically that using "notiflix.js", and "notiflix.css" files.
-* Version: 3.2.2
+* Version: 3.2.3
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 /* global define */

diff --git a/build/notiflix-notify-aio.js b/build/notiflix-notify-aio.js
@@ -1,9 +1,9 @@
 /*
 * Notiflix Notify AIO (https://notiflix.github.io)
 * Description: This file has been created automatically that using "notiflix.js", and "notiflix.css" files.
-* Version: 3.2.2
+* Version: 3.2.3
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 /* global define */

diff --git a/build/notiflix-report-aio.js b/build/notiflix-report-aio.js
@@ -1,9 +1,9 @@
 /*
 * Notiflix Report AIO (https://notiflix.github.io)
 * Description: This file has been created automatically that using "notiflix.js", and "notiflix.css" files.
-* Version: 3.2.2
+* Version: 3.2.3
 * Author: Furkan MT (https://github.com/furcan)
-* Copyright 2019 - 2021 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
+* Copyright 2019 - 2022 Notiflix, MIT Licence (https://opensource.org/licenses/MIT)
 */
 
 /* global define */

diff --git a/dist/notiflix-3.2.2.min.css → dist/notiflix-3.2.3.min.css b/dist/notiflix-3.2.2.min.css → dist/notiflix-3.2.3.min.css
diff --git a/dist/notiflix-3.2.2.min.js → dist/notiflix-3.2.3.min.js b/dist/notiflix-3.2.2.min.js → dist/notiflix-3.2.3.min.js
diff --git a/dist/notiflix-aio-3.2.2.min.js → dist/notiflix-aio-3.2.3.min.js b/dist/notiflix-aio-3.2.2.min.js → dist/notiflix-aio-3.2.3.min.js
diff --git a/dist/notiflix-block-aio-3.2.2.min.js → dist/notiflix-block-aio-3.2.3.min.js b/dist/notiflix-block-aio-3.2.2.min.js → dist/notiflix-block-aio-3.2.3.min.js
diff --git a/dist/notiflix-confirm-aio-3.2.2.min.js → dist/notiflix-confirm-aio-3.2.3.min.js b/dist/notiflix-confirm-aio-3.2.2.min.js → dist/notiflix-confirm-aio-3.2.3.min.js
diff --git a/dist/notiflix-loading-aio-3.2.2.min.js → dist/notiflix-loading-aio-3.2.3.min.js b/dist/notiflix-loading-aio-3.2.2.min.js → dist/notiflix-loading-aio-3.2.3.min.js
diff --git a/dist/notiflix-notify-aio-3.2.2.min.js → dist/notiflix-notify-aio-3.2.3.min.js b/dist/notiflix-notify-aio-3.2.2.min.js → dist/notiflix-notify-aio-3.2.3.min.js
diff --git a/dist/notiflix-report-aio-3.2.2.min.js → dist/notiflix-report-aio-3.2.3.min.js b/dist/notiflix-report-aio-3.2.2.min.js → dist/notiflix-report-aio-3.2.3.min.js