Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove quotes from installation instructions #19

Merged
merged 5 commits into from Nov 29, 2020
Merged

Remove quotes from installation instructions #19

merged 5 commits into from Nov 29, 2020

Conversation

ghost
Copy link

@ghost ghost commented Nov 10, 2020

This PR includes some minor changes to the README:

  • Change heading levels to conform to Markdown standards
  • Remove quotes from "~/.dir_colors" for symlink creation and testing commands

Fixes #15
Fixes #18
Related to #11

@ghost ghost mentioned this pull request Nov 10, 2020
@ghost
Copy link
Author

ghost commented Nov 10, 2020

Fixes #15.

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @michaelcusick 👋🏼 , thanks for your contribution 👍🏼

The actual install instruction fix looks good to me, but I've added some review comments.

CHANGELOG.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 29, 2020

@arcticicestudio Thanks for the review. I just made the changes.

Copy link
Contributor

@arcticicestudio arcticicestudio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for your contribution 👍🏼

@arcticicestudio arcticicestudio changed the title Readme formatting Remove quotes from installation instructions Nov 29, 2020
@arcticicestudio arcticicestudio merged commit 35166d3 into nordtheme:develop Nov 29, 2020
@arcticicestudio arcticicestudio unassigned ghost Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improper directory colors in iterm/tmux session readme instructions are incorrect
2 participants