Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting noobaa account state "rejected" #1509

Merged
merged 1 commit into from
Jan 16, 2025
Merged

Conversation

vh05
Copy link
Contributor

@vh05 vh05 commented Jan 16, 2025

Missing default_resource parameter which is mandatory parameter for account creation, should mark the nooobaa account status as rejected

Fixes: #https://issues.redhat.com/browse/DFBUGS-1297

@vh05 vh05 requested a review from dannyzaken January 16, 2025 09:57
@vh05 vh05 marked this pull request as draft January 16, 2025 09:57
@vh05 vh05 marked this pull request as ready for review January 16, 2025 10:00
@vh05 vh05 requested a review from liranmauda January 16, 2025 10:00
@liranmauda
Copy link
Contributor

liranmauda commented Jan 16, 2025

@vh05 Why do we only return util.NewPersistentError on the update?
Don't we need to return util.NewPersistentError in the creation?

accountInfo, err := r.NBClient.CreateAccountAPI(createAccountParams)
if err != nil {
return err
}

Missing default_resource parameter which is mandatory
parameter for account creation, should mark the nooobaa
account status as rejected

Fixes: #https://issues.redhat.com/browse/DFBUGS-1297

Signed-off-by: Vinayak Hariharmath <[email protected]>
@vh05 vh05 merged commit 1bf199c into noobaa:master Jan 16, 2025
14 checks passed
@vh05 vh05 deleted the dfbugs-1297 branch January 16, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants