Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nsfs - add mounted nsr name to env. DFBUGS-153 #1481

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

nsfs - add mounted nsr name to env. DFBUGS-153 #1481

wants to merge 1 commit into from

Conversation

alphaprinz
Copy link
Contributor

Explain the changes

  1. Add an env variable for each nsfs nsr mount.
    This way endpoints have a way to tell whether an nsr (that they get from system store) should be mounted or not.

Issues: Fixed #xxx / Gap #xxx

Testing Instructions:

  1. Reduce config.NAMESPACE_MONITOR_DELAY to 1000ms.
  2. Create nsfs nsr
  3. nsr should not be rejected (by endpoints existing before its creation).
  • Doc added/updated
  • Tests added

@alphaprinz alphaprinz mentioned this pull request Nov 28, 2024
Open
2 tasks
@alphaprinz alphaprinz force-pushed the 153_nsfs_nsr_rejected_take2 branch from e602b40 to 35bff1f Compare December 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romayalon romayalon Awaiting requested review from romayalon

@shirady shirady Awaiting requested review from shirady

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alphaprinz