Removed Mongo related code and files #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyzaken
force-pushed
the
danny-remove-upgrade
branch
3 times, most recently
from
e9e45ac to
f2ee93e
Compare
liranmauda
reviewed
Mar 31, 2024
README.md
Outdated
| --db-storage-class='': The database volume storage class name | ||
| --db-type='postgres': The type of database container image (mongodb, postgres) | ||
| --db-type='postgres': The type of database container image (postgres) |
There was a problem hiding this comment.
why do we need this flag?
Can we remove it?
There was a problem hiding this comment.
I removed all references to DBType in the code. Left it in the CRD, but basically ignoring it
dannyzaken
force-pushed
the
danny-remove-upgrade
branch
from
f2ee93e to
b58a6f1
Compare
dannyzaken
force-pushed
the
danny-remove-upgrade
branch
from
b58a6f1 to
fe70713
Compare
jackyalbo
reviewed
Apr 1, 2024
README.md
Outdated
| @@ -143,9 +143,8 @@ The following options can be passed to any command: | |||
| --aws-sts-arn='': The AWS STS Role ARN which will assume role | |||
| --cosi-driver-path='/var/lib/cosi/cosi.sock': unix socket path for COSI | |||
| --cosi-sidecar-image='gcr.io/k8s-staging-sig-storage/objectstorage-sidecar/objectstorage-sidecar:v20221117-v0.1.0-22-g0e67387': The cosi side car container image | |||
| --db-image='centos/mongodb-36-centos7': The database container image | |||
| --db-image='"quay.io/sclorg/postgresql-15-c9s"': The database container image | |||
There was a problem hiding this comment.
remove second quotes:
Suggested change
| --db-image='"quay.io/sclorg/postgresql-15-c9s"': The database container image | |
| --db-image='quay.io/sclorg/postgresql-15-c9s': The database container image |
| @@ -85,9 +85,10 @@ type NooBaaSpec struct { | |||
| // +optional | |||
| DBConf *string `json:"dbConf,omitempty"` | |||
|
|
|||
| // DBType (optional) overrides the default type image for the db container | |||
| // DBType (optional) overrides the default type image for the db container. | |||
| // The only possible value is postgres | |||
There was a problem hiding this comment.
shouldn't we just remove this?
Removed all mongo related code: * Making DBType to only accept postgres * removed mongo external URL * removed mongo related envs from deployments\statefulsets * remove Mongo related CLI commands (e.g. dbdump) Signed-off-by: Danny Zaken <[email protected]>
dannyzaken
force-pushed
the
danny-remove-upgrade
branch
from
fe70713 to
79816d9
Compare
jackyalbo
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed all mongo related code:
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: