Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package github.com/openshift/api #1232

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

shirady
Copy link
Contributor

@shirady shirady commented Oct 23, 2023

Explain the changes

  1. Update package github.com/openshift/api

Issues: Fixed #xxx / Gap #xxx

  1. none

Testing Instructions:

Local cluster:

Deploy noobaa on MInikube or Rancher Desktop (see guide).
Note: nb is an alias that runs the local operator from build/_output/bin (alias created by devenv).

  1. Run: . ./devenv.sh
  2. Build the image make all.
  3. Install noobaa nb install --dev --noobaa-image <noobaa-core-image> -n <my-namespace>

Remote cluster:

Using cluster bot 'launch aws 4.14'

  1. Run: . ./devenv.sh
  2. Build the image (added flag to build for Linux since I have MacOS): DOCKER_DEFAULT_PLATFORM=linux/amd64 GOARCH=amd64 make all.
  3. Then tag it to your Quay account and push the image:
    docker tag noobaa/noobaa-operator:5.15.0 quay.io/<my-user>/noobaa-operator:<my-tag>
    docker push quay.io/<my-user>/noobaa-operator:<my-tag>
  4. Install noobaa nb install --dev --noobaa-image '<noobaa-image-from-docker-hub>' --operator-image 'quay.io/<my-user>/noobaa-operator:<my-tag>' -n <my-namespace>
  • Doc added/updated
  • Tests added

@shirady
Copy link
Contributor Author

shirady commented Oct 23, 2023

Additional instructions on how I installed the package:

I tried to update by running: go get -u github.com/openshift/api and got errors:

	github.com/openshift/api imports
		k8s.io/api/batch/v2alpha1: cannot find module providing package k8s.io/api/batch/v2alpha1
	github.com/openshift/api imports
		k8s.io/api/settings/v1alpha1: cannot find module providing package k8s.io/api/settings/v1alpha1

Moved to manual steps:

  1. Delete the line of github.com/openshift/api
    (it was github.com/openshift/api v3.9.1-0.20190924102528-32369d4db2ad+incompatible)
  2. Install the an updated package: go get -u github.com/openshift/api
  3. Then run:
    make vendor
    make gen ; make gen-api ; make
  4. I saw that the package was added in a separate require, so I moved it to the line it was originally deleted and ran:
    make clean
    make vendor
    make gen ; make gen-api ; make

@shirady shirady self-assigned this Oct 23, 2023
@shirady shirady requested a review from dannyzaken October 23, 2023 09:25
@shirady shirady merged commit ce1cdaa into noobaa:master Oct 23, 2023
14 checks passed
@shirady shirady deleted the update-package-openshift-api branch October 24, 2023 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants