Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #140 bug, the old typescript version problem #141

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix #140 bug, the old typescript version problem #141

merged 2 commits into from
Dec 6, 2023

Conversation

samchon
Copy link
Contributor

@samchon samchon commented Dec 6, 2023 •
edited
Loading

Add checking logic whether tsShim.JSDocParsingMode, so that fixes the bug from old TypeScript version.

@nonara Hope 3.1.1 patch, and deprecation of 3.1.0 version.

@samchon samchon changed the title Fix #140 bug Fix #140 bug, the old typescript version problem Dec 6, 2023
@samchon
Copy link
Contributor Author

samchon commented Dec 6, 2023

Thanks for quick response.

@nonara
Copy link
Owner

nonara commented Dec 6, 2023

Good catch. Thanks!

@nonara nonara merged commit d21e02e into nonara:master Dec 6, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samchon @nonara