Skip to content

Conversation

@nojimage nojimage self-assigned this Dec 2, 2025
@nojimage nojimage marked this pull request as ready for review December 2, 2025 11:43
@nojimage nojimage requested a review from Copilot December 2, 2025 11:44
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds support for PHP 8.4 by updating type hints to use modern nullable syntax, updating dependencies, and modernizing the CI configuration.

Key Changes:

  • Updated type hints across multiple classes to use nullable syntax (?Type) instead of docblock-only type hints
  • Updated CI workflow to test PHP versions 7.4 through 8.5, with PHP 8.4 as the default for coverage and code style checks
  • Updated dependencies to support newer versions of symfony/yaml and twitter/twitter-text

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/bootstrap.php Removed deprecated E_STRICT constant from error reporting
lib/Twitter/Text/Validator.php Added nullable type hints and updated return type annotations to use self
lib/Twitter/Text/Parser.php Added nullable type hints and updated return type annotations to use self
lib/Twitter/Text/HitHighlighter.php Added nullable type hints and updated return type annotations to use self
lib/Twitter/Text/Extractor.php Updated return type annotation to use self
lib/Twitter/Text/Configuration.php Added nullable type hints, updated return type annotations to use self, and changed instantiation to use self
lib/Twitter/Text/Autolink.php Added nullable type hints and updated return type annotations to use static
composer.json Updated symfony/yaml and twitter/twitter-text version constraints
.github/workflows/ci.yml Updated to test PHP 8.3-8.5, modernized GitHub Actions, and improved CI configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@nojimage nojimage merged commit 0fb0629 into master Dec 2, 2025
8 checks passed
@nojimage nojimage deleted the support-php84 branch December 2, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants