Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove debug log #88

Merged
merged 1 commit into from
Sep 4, 2024
Merged

chore: remove debug log #88

merged 1 commit into from
Sep 4, 2024

Conversation

asterite
Copy link
Contributor

@asterite asterite commented Sep 4, 2024

Description

Problem

The LSP client logs "Starting LSP client using command: ${command} ${args}" on every LSP interaction, not just when the LSP client starts, so that showing out in the output is confusing but also a bit distracting (especially if you are trying to see the actual messages that go between the client and server).

Also, now that we'll show (for now) comptime output in the logs, it's nice if we don't get this extra line for each "compilation".

Summary

Removes that log line.

Additional Context

When do we do releases of the extension?

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite requested a review from a team September 4, 2024 10:36
@jfecher jfecher merged commit f9c94a0 into master Sep 4, 2024
4 checks passed
@jfecher jfecher deleted the ab/remove-debug branch September 4, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants