Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aztec): search for aztec-nargo on top of nargo bin #67

Merged
merged 6 commits into from
Mar 4, 2024

Conversation

kobyhallx
Copy link
Contributor

@kobyhallx kobyhallx commented Feb 12, 2024

Partialy resolves

LSP to set nargo path based on nargo or aztec-nargo #4233,

Adds

image

Status Bar item with information about nargo picked.

Indicates with colour and diagnostic message otherwise

image

Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's some issues related to defaulting to aztec-nargo in all cases. We should ensure that we use vanilla nargo in standard noir projects.

src/find-nargo.ts Outdated Show resolved Hide resolved
src/find-nargo.ts Outdated Show resolved Hide resolved
@TomAFrench
Copy link
Member

We should also make sure to handle the edge case where the user has a workspace which contains a mix of contracts and other package types. In this case we should use aztec-nargo to ensure we are using a consistent version of nargo across the entire workspace.

@TomAFrench
Copy link
Member

Agreed in call that automatic handling of the different versions shouldn't be a requirement for this PR as that would prevent us from moving forwards on this until the next nargo release. Instead we're going to make the status icon clickable to switch between found versions of nargo.

@TomAFrench TomAFrench merged commit 0be02a5 into master Mar 4, 2024
4 checks passed
@TomAFrench TomAFrench deleted the kh-search-aztec-nargo#4233 branch March 4, 2024 12:15
@github-actions github-actions bot mentioned this pull request Feb 27, 2024
TomAFrench added a commit that referenced this pull request Mar 4, 2024
* master:
  feat(aztec): search for aztec-nargo on top of nargo bin (#67)
  feat: add `unchecked` keyword highlighting (#72)
  feat: add keyword highlighting for databus visibility keywords (#68)
  chore: Remove format on save override (#65)
  chore: Remove environment reference (#62)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants