Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update github action example for newer versions #33

Merged
merged 3 commits into from
Jun 23, 2023

Conversation

sambarnes
Copy link
Contributor

Related issue(s)

Resolves #32

Description

Summary of changes

fixes the readme & bumps version so newcomers more likely to pin latest

Dependency additions / changes

N/A

Test additions / changes

N/A

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

@sambarnes
Copy link
Contributor Author

was originally trying to slip into @TomAFrench 's branch here: #30

but feel free to change the base to whatever you want

@TomAFrench TomAFrench changed the base branch from release-please--branches--main--components--noirup to main June 16, 2023 03:57
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for updating version to toolchain, we must have missed that.

I've changed the base to main as the original branch is an automated release branch which we shouldn't build on top of (it just handles making a release with the contents of main).

README.md Outdated Show resolved Hide resolved
@phated phated changed the title chore: fix github action example in README & bump versions chore: Update github action example for newer versions Jun 23, 2023
@phated phated merged commit e310f62 into noir-lang:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README using outdated GH Actions inputs
3 participants