Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use loops instead of recursion #21

Merged
merged 11 commits into from
Feb 11, 2025
Merged

feat: use loops instead of recursion #21

merged 11 commits into from
Feb 11, 2025
+125 −46

Conversation

michaeljklein
Copy link
Contributor

@michaeljklein michaeljklein commented Feb 4, 2025 •
edited
Loading

Description

Problem*

Resolves noir-lang/noir#7213

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

TomAFrench
TomAFrench reviewed Feb 4, 2025
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of maintaining the recursive implementations? Assuming this is still here just for validating correctness for now, can remove when we're closer to merging.

src/quicksort/quicksort_recursive.nr Outdated Show resolved Hide resolved
src/quicksort/quicksort_recursive_explicit.nr Outdated Show resolved Hide resolved
@michaeljklein michaeljklein marked this pull request as ready for review February 4, 2025 18:32
TomAFrench
TomAFrench reviewed Feb 7, 2025
View reviewed changes
src/lib.nr Outdated Show resolved Hide resolved
TomAFrench
TomAFrench approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nits but otherwise LGTM

src/quicksort/quicksort.nr Outdated Show resolved Hide resolved
src/quicksort/quicksort.nr Outdated Show resolved Hide resolved
src/quicksort/quicksort.nr Outdated Show resolved Hide resolved
src/quicksort/quicksort_explicit.nr Outdated Show resolved Hide resolved
src/quicksort/quicksort_explicit.nr Outdated Show resolved Hide resolved
michaeljklein and others added 2 commits February 7, 2025 15:32
@michaeljklein michaeljklein mentioned this pull request Feb 7, 2025
Open
@michaeljklein michaeljklein merged commit 153fb72 into main Feb 11, 2025
8 checks passed
@github-actions github-actions bot mentioned this pull request Feb 11, 2025
Open
@michaeljklein michaeljklein mentioned this pull request Feb 13, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfecher jfecher jfecher approved these changes

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@michaeljklein @jfecher @TomAFrench