Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: update to noir-bignum v0.4.1 #30

Merged
merged 12 commits into from
Nov 8, 2024
Merged

feat!: update to noir-bignum v0.4.1 #30

merged 12 commits into from
Nov 8, 2024

Conversation

TomAFrench
Copy link
Member

Pulling in #29 as @iAmMichaelConnor's repo wont allow me to push to it.

@TomAFrench
Copy link
Member Author

@iAmMichaelConnor Looks like the signature generation needs to be updated so that it outputs the new bignum param fields which got added in your refactor.

@iAmMichaelConnor
Copy link
Collaborator

iAmMichaelConnor commented Nov 8, 2024

I think I've updated the signature_gen/main.rs file to generate the data?
The aspect of the signature_gen/main.rs file that I didn't touch yet is the functionality to print to toml - is that what you're referring to?
Interestingly, if I check out this branch and run nargo test using noir 0.36.0, all tests pass? EDIT: oh no, the example/ dir tests fail because that requires a new Noir release.

@iAmMichaelConnor
Copy link
Collaborator

Ohhh, it's testing via nargo execute - ok, yeah I'll update the toml code generator.

e sig gen code for prover.toml of example dir
@iAmMichaelConnor
Copy link
Collaborator

I changed the main function in examples/ so that the data in the Prover.toml is easier to generate (I don't want to bother generating the u60 versions of the modulus).
The upshot of that is: this PR is compatible with Noir v0.36.0, so we don't need to wait for a new release of Noir.

The downside is: that pesky bug where nargo compile of examples/ causes a compiler error disappears, lost forever.

@TomAFrench TomAFrench merged commit e54d13d into main Nov 8, 2024
5 checks passed
@TomAFrench TomAFrench deleted the tf/update-bignum branch November 8, 2024 15:32
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
This was referenced Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants