Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add type declarations to globals #21

Merged
merged 2 commits into from
Nov 25, 2024
Merged

fix: add type declarations to globals #21

merged 2 commits into from
Nov 25, 2024

Conversation

kashbrti
Copy link
Contributor

@kashbrti kashbrti commented Nov 25, 2024 •
edited
Loading

Description

globals are now required to have their types specified.
There were a bunch of them in the lib that didn't.

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench changed the title fix: fixed tests failing with latest nightly fix: add type declarations to globals Nov 25, 2024
TomAFrench
TomAFrench approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomAFrench TomAFrench merged commit c32dcd5 into main Nov 25, 2024
8 checks passed
@TomAFrench TomAFrench deleted the kh/fix_nightly branch November 25, 2024 10:38
@github-actions github-actions bot mentioned this pull request Nov 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kashbrti @TomAFrench