Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: replace fixed size JSON modules with type aliases #19

Merged
merged 1 commit into from
Jan 8, 2025
Merged

chore!: replace fixed size JSON modules with type aliases #19

merged 1 commit into from
Jan 8, 2025
+11 −1,293

Conversation

TomAFrench
Copy link
Member

Description

Problem*

Resolves #10

Summary*

This replaces a load of duplicated code with proper type aliases.

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench TomAFrench requested a review from kashbrti November 8, 2024 02:27
@TomAFrench TomAFrench mentioned this pull request Jan 8, 2025
Open
2 tasks
@TomAFrench
Copy link
Member Author

@kashbrti

kashbrti
kashbrti approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@kashbrti kashbrti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib.nr Show resolved Hide resolved
@TomAFrench TomAFrench merged commit e5669b6 into main Jan 8, 2025
5 checks passed
@github-actions github-actions bot mentioned this pull request Jan 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashbrti kashbrti kashbrti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modules named JSON512b, JSON1kb, etc. should be replaced with type aliases.
2 participants
@TomAFrench @kashbrti