Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules named JSON512b, JSON1kb, etc. should be replaced with type aliases. #10

Open
TomAFrench opened this issue Sep 27, 2024 · 0 comments · May be fixed by #19
Open

Modules named JSON512b, JSON1kb, etc. should be replaced with type aliases. #10

TomAFrench opened this issue Sep 27, 2024 · 0 comments · May be fixed by #19

Comments

@TomAFrench
Copy link
Member

These modules are basically acting as type aliases, we should replace these with type aliases which provide concrete values for the generics on JSON.

I expect there would be some errors which appear as a result of this which will fuel some changes in the Noir compiler.
@TomAFrench TomAFrench linked a pull request Nov 8, 2024 that will close this issue
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore!: replace fixed size JSON modules with type aliases noir-lang/noir_json_parser
1 participant
@TomAFrench