Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove tests from
impl
blocks, dedupe test names.Additional Context
Tests now fail for
msm
onSecp256r1
,MNT6_753
,MNT4_753
, andSecp384r1
curves. I'm unsure whatmsm
means, but the error originates in theCurve::evaluate_linear_expression
method and fails in__compute_quadratic_expression_with_borrow_flags
from the noir-bignum library, specifically: