Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ssa): Use correct prefix when printing array values in global space #7095

Merged
merged 1 commit into from
Jan 16, 2025

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Jan 16, 2025

Description

Problem*

No issue just little thing I found that was bugging me.

Printing global arrays currently looks like this:

g0 = Field 1
g1 = make_array [Field 1, Field 1] : [Field; 2]
g2 = Field 0
g3 = make_array [Field 0, Field 0] : [Field; 2]
g4 = make_array [v1, v3] : [[Field; 2]; 2]

However, the last line should look like this: g4 = make_array [g1, g3] : [[Field; 2]; 2]

Summary*

I account for whether we are in the global space when printing elements from MakeArray.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm requested a review from a team January 16, 2025 19:37
@TomAFrench TomAFrench enabled auto-merge January 16, 2025 19:41
Copy link
Contributor

Compilation Report

Program Compilation Time %
sha256_regression 1.050s 1%
regression_4709 0.792s -6%
ram_blowup_regression 16.200s 1%
rollup-root 3.662s 6%
rollup-merge 2.166s 2%
rollup-block-root-single-tx 136.000s -9%
rollup-block-root-empty 2.122s -4%
rollup-block-root 141.000s 1%
rollup-block-merge 3.496s -3%
rollup-base-public 28.920s -3%
rollup-base-private 10.200s 2%
private-kernel-tail 1.005s -9%
private-kernel-reset 6.084s -4%
private-kernel-inner 1.978s -4%

Copy link
Contributor

Execution Report

Program Execution Time %
sha256_regression 0.051s 0%
regression_4709 0.001s 0%
ram_blowup_regression 0.598s -1%
rollup-root 0.105s 0%
rollup-merge 0.006s 0%
rollup-block-root 36.400s -6%
rollup-block-merge 0.103s 0%
rollup-base-public 1.216s -1%
rollup-base-private 0.451s 0%
private-kernel-tail 0.019s -6%
private-kernel-reset 0.311s 0%
private-kernel-inner 0.068s 0%

@TomAFrench TomAFrench added this pull request to the merge queue Jan 16, 2025
Copy link
Contributor

Compilation Memory Report

Program Peak Memory
keccak256 77.65M
workspace 123.83M
regression_4709 424.15M
ram_blowup_regression 1.46G
rollup-root 601.26M
rollup-merge 494.24M
rollup-block-root-single-tx 16.06G
rollup-block-root-empty 488.41M
rollup-block-root 16.07G
rollup-block-merge 601.26M
rollup-base-public 2.38G
rollup-base-private 1.14G
private-kernel-tail 207.47M
private-kernel-reset 584.49M
private-kernel-inner 294.68M

Copy link
Contributor

Execution Memory Report

Program Peak Memory
keccak256 74.71M
workspace 123.76M
regression_4709 316.02M
ram_blowup_regression 512.62M
rollup-root 498.31M
rollup-merge 473.05M
rollup-block-root 1.22G
rollup-block-merge 498.33M
rollup-base-public 734.18M
rollup-base-private 590.51M
private-kernel-tail 180.91M
private-kernel-reset 245.52M
private-kernel-inner 208.92M

Merged via the queue into master with commit ad5a980 Jan 16, 2025
103 checks passed
@TomAFrench TomAFrench deleted the mv/ssa-print-global-arr-values-fix branch January 16, 2025 19:56
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 17, 2025
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 18, 2025
…oir-lang/noir#7100)

feat: Parser and formatter support for `enum`s (noir-lang/noir#7110)
feat(brillig): SSA globals code gen (noir-lang/noir#7021)
feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096)
chore: Add benchmarking dashboard (noir-lang/noir#7068)
feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088)
feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106)
chore: Cookbook Onboard integration (noir-lang/noir#7044)
chore: lock to ubuntu 22.04 (noir-lang/noir#7098)
fix: Remove unused brillig functions (noir-lang/noir#7102)
chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 18, 2025
…oir#7100)

feat: Parser and formatter support for `enum`s (noir-lang/noir#7110)
feat(brillig): SSA globals code gen (noir-lang/noir#7021)
feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096)
chore: Add benchmarking dashboard (noir-lang/noir#7068)
feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088)
feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106)
chore: Cookbook Onboard integration (noir-lang/noir#7044)
chore: lock to ubuntu 22.04 (noir-lang/noir#7098)
fix: Remove unused brillig functions (noir-lang/noir#7102)
chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 19, 2025
…oir-lang/noir#7100)

feat: Parser and formatter support for `enum`s (noir-lang/noir#7110)
feat(brillig): SSA globals code gen (noir-lang/noir#7021)
feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096)
chore: Add benchmarking dashboard (noir-lang/noir#7068)
feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088)
feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106)
chore: Cookbook Onboard integration (noir-lang/noir#7044)
chore: lock to ubuntu 22.04 (noir-lang/noir#7098)
fix: Remove unused brillig functions (noir-lang/noir#7102)
chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)
AztecBot added a commit to AztecProtocol/aztec-packages that referenced this pull request Jan 19, 2025
…oir#7100)

feat: Parser and formatter support for `enum`s (noir-lang/noir#7110)
feat(brillig): SSA globals code gen (noir-lang/noir#7021)
feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096)
chore: Add benchmarking dashboard (noir-lang/noir#7068)
feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088)
feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106)
chore: Cookbook Onboard integration (noir-lang/noir#7044)
chore: lock to ubuntu 22.04 (noir-lang/noir#7098)
fix: Remove unused brillig functions (noir-lang/noir#7102)
chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants