feat(brillig): SSA globals code gen #7021

vezenovm · 2025-01-10T16:55:34Z

Description

Problem*

Resolves #6801

Summary*

Implements globals from SSA in Brillig gen. We create a new memory space GlobalSpace at compile time. Globals are declared in the global space and the linker is then used to connect these with our SSA functions.

The global brillig variables that are allocated are then passed to every BrilligBlock. When converting SSA values for a function's block we check whether we have a global and if so, look for the appropriate register that keys into the appropriate slot in the global space.

Additional Context

Some slight regressions are expected. Some reasons for this are laid out here #7021 (comment).

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

…obals-1

…rc/main.nr

Co-authored-by: jfecher <[email protected]>

… mv/ssa-globals-brillig-gen

compiler/noirc_evaluator/src/ssa/parser/into_ssa.rs

tooling/nargo/src/errors.rs

TomAFrench · 2025-01-16T21:03:33Z

I look to be getting failures post AztecProtocol/aztec-packages#10605.

I assume that this is from the roots global. This isn't used in brillig code currently so I imagine this would be solved by the die pass PR

That said, as we know all of the globals at compile time we should be able to expand the space allocated as necessary. If so can you create a follow up issue?

vezenovm · 2025-01-16T21:12:55Z

That said, as we know all of the globals at compile time we should be able to expand the space allocated as necessary. If so can you create a follow up issue?

Yeah I'll make an issue for the max global space to be determined by the program rather than a hardcoded value.

compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs

compiler/noirc_evaluator/src/ssa/opt/die.rs

compiler/noirc_evaluator/src/ssa/ir/map.rs

vezenovm · 2025-01-17T16:54:56Z

That said, as we know all of the globals at compile time we should be able to expand the space allocated as necessary. If so can you create a follow up issue?

#7107

…oir-lang/noir#7100) feat: Parser and formatter support for `enum`s (noir-lang/noir#7110) feat(brillig): SSA globals code gen (noir-lang/noir#7021) feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096) chore: Add benchmarking dashboard (noir-lang/noir#7068) feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088) feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106) chore: Cookbook Onboard integration (noir-lang/noir#7044) chore: lock to ubuntu 22.04 (noir-lang/noir#7098) fix: Remove unused brillig functions (noir-lang/noir#7102) chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)

…oir#7100) feat: Parser and formatter support for `enum`s (noir-lang/noir#7110) feat(brillig): SSA globals code gen (noir-lang/noir#7021) feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096) chore: Add benchmarking dashboard (noir-lang/noir#7068) feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088) feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106) chore: Cookbook Onboard integration (noir-lang/noir#7044) chore: lock to ubuntu 22.04 (noir-lang/noir#7098) fix: Remove unused brillig functions (noir-lang/noir#7102) chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)

…oir-lang/noir#7100) feat: Parser and formatter support for `enum`s (noir-lang/noir#7110) feat(brillig): SSA globals code gen (noir-lang/noir#7021) feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096) chore: Add benchmarking dashboard (noir-lang/noir#7068) feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088) feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106) chore: Cookbook Onboard integration (noir-lang/noir#7044) chore: lock to ubuntu 22.04 (noir-lang/noir#7098) fix: Remove unused brillig functions (noir-lang/noir#7102) chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)

…oir#7100) feat: Parser and formatter support for `enum`s (noir-lang/noir#7110) feat(brillig): SSA globals code gen (noir-lang/noir#7021) feat: `loop` keyword in runtime and comptime code (noir-lang/noir#7096) chore: Add benchmarking dashboard (noir-lang/noir#7068) feat(experimental): try to infer lambda argument types inside calls (noir-lang/noir#7088) feat(ssa): Add flag to DIE pass to be able to keep `store` instructions (noir-lang/noir#7106) chore: Cookbook Onboard integration (noir-lang/noir#7044) chore: lock to ubuntu 22.04 (noir-lang/noir#7098) fix: Remove unused brillig functions (noir-lang/noir#7102) chore(ssa): Use correct prefix when printing array values in global space (noir-lang/noir#7095)

vezenovm and others added 30 commits January 8, 2025 02:46

cleanup global generation with GlobalsBuilder

c7d8009

all tests paassing

4b19a7b

cargo fmt

c8e08d3

fmt and clippy

8a24746

some comments for context

e3358e3

nargo fmt

c3948fe

merge master and conflicts w/ printer

328004e

remove type from Value::Global and cleanup

40c50fc

bring back global type

7744179

Update compiler/noirc_evaluator/src/ssa/ssa_gen/context.rs

68ddd14

only print globals when printing ssa if globals exist

6823019

Merge remote-tracking branch 'origin/mv/ssa-globals-1' into mv/ssa-gl…

73ceea5

…obals-1

make an eval method

cbe377e

Update compiler/noirc_evaluator/src/ssa/ssa_gen/context.rs

2d750fb

Update compiler/noirc_evaluator/src/ssa/ssa_gen/context.rs

faeb30f

Update test_programs/execution_success/global_var_regression_simple/s…

2322cb6

…rc/main.nr

Merge branch 'master' into mv/ssa-globals-1

08a2aba

cargo mft

fa6d9cf

Merge branch 'master' into mv/ssa-globals-1

200964f

working brillig implementation of globals

5bbe0c9

merge conflicts w/ master

f98c713

Merge branch 'mv/ssa-globals-1' into mv/ssa-globals-brillig-gen

2bff6eb

Merge branch 'master' into mv/ssa-globals-1

ad19fc3

Update compiler/noirc_frontend/src/hir/comptime/value.rs

bb5a9ea

Co-authored-by: jfecher <[email protected]>

make separate BrilligsGlobal struct

fa0122d

do ot duplicate codegen

74a7358

Merge branch 'master' into mv/ssa-globals-1

df5eef0

merge conflcits w/ mv/ssa-globals-1

eaacac8

some fixes and fmt after merge

91c0c35

re-use codegen methods for BrilligBlock

94683e6

Merge remote-tracking branch 'origin/mv/ssa-globals-brillig-gen' into…

9e39938

… mv/ssa-globals-brillig-gen

vezenovm commented Jan 16, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/parser/into_ssa.rs Outdated Show resolved Hide resolved

Update compiler/noirc_evaluator/src/ssa/parser/into_ssa.rs

06693f4

vezenovm commented Jan 16, 2025

View reviewed changes

tooling/nargo/src/errors.rs Outdated Show resolved Hide resolved

Update tooling/nargo/src/errors.rs

3ebb4a8

feat(ssa): Globals DIE (#7081)

fe7f8b6

TomAFrench reviewed Jan 16, 2025

View reviewed changes

compiler/noirc_evaluator/src/brillig/brillig_gen/brillig_block.rs Outdated Show resolved Hide resolved

TomAFrench reviewed Jan 17, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/opt/die.rs Show resolved Hide resolved

TomAFrench reviewed Jan 17, 2025

View reviewed changes

compiler/noirc_evaluator/src/ssa/ir/map.rs Outdated Show resolved Hide resolved

vezenovm added 2 commits January 17, 2025 14:26

remove unnecessary lifetime and update map

b21bb69

Merge branch 'master' into mv/ssa-globals-brillig-gen

f7b7348

vezenovm requested a review from TomAFrench January 17, 2025 14:28

vezenovm added 2 commits January 17, 2025 16:37

merge conflicts w/ master

f934a94

use DoubleEndedIterator

66bf286

vezenovm mentioned this pull request Jan 17, 2025

Do not hardcode the maximum global memory space #7107

Open

vezenovm mentioned this pull request Jan 17, 2025

Hoist constants shared across functions into the global space #7109

Open

TomAFrench approved these changes Jan 17, 2025

View reviewed changes

TomAFrench added this pull request to the merge queue Jan 17, 2025

Merged via the queue into master with commit 82cb900 Jan 17, 2025
101 checks passed

TomAFrench deleted the mv/ssa-globals-brillig-gen branch January 17, 2025 18:57

noirwhal mentioned this pull request Jan 17, 2025

chore: Release Noir(1.0.0-beta.2) #6914

Open

AztecBot mentioned this pull request Jan 18, 2025

feat: Sync from noir AztecProtocol/aztec-packages#11294

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(brillig): SSA globals code gen #7021

feat(brillig): SSA globals code gen #7021

vezenovm commented Jan 10, 2025 •

edited

Loading

TomAFrench commented Jan 16, 2025

vezenovm commented Jan 16, 2025 •

edited

Loading

vezenovm commented Jan 17, 2025

feat(brillig): SSA globals code gen #7021

feat(brillig): SSA globals code gen #7021

Conversation

vezenovm commented Jan 10, 2025 • edited Loading

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

TomAFrench commented Jan 16, 2025

vezenovm commented Jan 16, 2025 • edited Loading

vezenovm commented Jan 17, 2025

vezenovm commented Jan 10, 2025 •

edited

Loading

vezenovm commented Jan 16, 2025 •

edited

Loading