New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jf/memtest #6753

Draft

jfecher wants to merge 6 commits into master from jf/memtest

Contributor

jfecher commented Dec 10, 2024

Description

Problem*

Resolves

Summary*

Variant of #6747 to see the upper bound on memory saved if we did not track call stacks.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

jfecher and others added 5 commits

December 9, 2024 14:37


          Try replace callstack with a linked list

db68fac


          Fix unit tests

d427768


          Clippy

d304ebc


          Format

7ed0bf4


          Test memory usage of location

Contributor

github-actions bot commented Dec 10, 2024 •

edited

Loading

Compilation Sample

Program	Compilation Time	%
sha256_regression	0m0.806s	-44%
regression_4709	0m1.534s	2%
ram_blowup_regression	0m11.796s	-30%
private-kernel-tail	0m0.962s	-30%
private-kernel-reset	0m5.541s	-46%
private-kernel-inner	0m1.637s	-34%
parity-root	0m0.774s	-23%
noir-contracts	2m19.929s	-18%

Contributor

github-actions bot commented Dec 10, 2024 •

edited

Loading

Peak Memory Sample

Program	Peak Memory	%
keccak256	77.59M	-5%
workspace	121.89M	0%
regression_4709	285.22M	-15%
ram_blowup_regression	2.40G	0%
private-kernel-tail	202.30M	-13%
private-kernel-reset	714.48M	100%
private-kernel-inner	281.41M	-17%
parity-root	168.79M	-16%

jfecher mentioned this pull request

chore: Try replace callstack with a linked list #6747

Merged

5 tasks


          Merge branch 'master' into jf/memtest

08c8998

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet