New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Experiment changing BoundedVec::eq #6690

Closed

jfecher wants to merge 1 commit into master from jf/bounded-vec

Contributor

jfecher commented Dec 3, 2024

Description

Problem*

Summary*

Seeing how much worse the constraint counts are for BoundedVec if eq were changed to not check elements past the length.

Additional Context

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.


          Experiment with eq change

2eebd39

Contributor

github-actions bot commented Dec 3, 2024

Peak Memory Sample

Program	Peak Memory
keccak256	83.10M
workspace	121.93M
regression_4709	333.56M
ram_blowup_regression	2.65G

Contributor Author

jfecher commented Dec 3, 2024

Hmm, looks like we don't have any tests that use bounded vec eq or pop dynamically

jfecher closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet