chore: add a few regression tests for #6674 #6687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Peak Memory Sample
|
asterite
changed the title
asterite
changed the title
TomAFrench
approved these changes
Dec 6, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 6, 2024
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 7, 2024
…#6650) fix: git dependency trailing slash (noir-lang/noir#6725) chore: optimise older opcodes in reverse order (noir-lang/noir#6476) chore: add script to check for critical libraries supporting a given Noir version (noir-lang/noir#6697) fix!: several format string fixes and improvements (noir-lang/noir#6703) fix: print ssa blocks without recursion (noir-lang/noir#6715) chore: redo typo PR by Madmaxs2 (noir-lang/noir#6721) chore: add a few regression tests for #6674 (noir-lang/noir#6687)
AztecBot
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 7, 2024
fix: git dependency trailing slash (noir-lang/noir#6725) chore: optimise older opcodes in reverse order (noir-lang/noir#6476) chore: add script to check for critical libraries supporting a given Noir version (noir-lang/noir#6697) fix!: several format string fixes and improvements (noir-lang/noir#6703) fix: print ssa blocks without recursion (noir-lang/noir#6715) chore: redo typo PR by Madmaxs2 (noir-lang/noir#6721) chore: add a few regression tests for #6674 (noir-lang/noir#6687)
TomAFrench
added a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Dec 7, 2024
Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: add a few regression tests for #6674 (noir-lang/noir#6687) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Resolves #6674
Summary
Doesn't resolve the issue yet, it just contains three test programs that exhibit the issue. The three test programs are similar but they were reduced from three different tests that failed for different reasons (some tests started to pass with some fixes but others broke: I think these three cover most of the scenarios we saw were failing).
Additional Context
Documentation
Check one:
PR Checklist
cargo fmton default settings.