feat(ssa): Implement missing brillig constraints SSA check #6658

rkarabut · 2024-11-29T18:51:23Z

Description

This adds a new check to the security SSA passes module warning the developer about insufficiently constrained brillig calls.

Problem

Brillig function calls not properly constrained by a later assert should be reported as bugs, as they present potential soundness vulnerabilities. This is referenced in and resolves #5425.

Summary

For now, we consider descendant values of every call result value and at least one of the argument values (if there are any) being involved in a set of constraint instructions proper coverage. If a result value itself (and not its descendant) is constrained (against a constant, for example), that too is currently considered proper. To check for it, we collect the descendant value ids for each brillig call met in a function and check them against constraints met later. If any of the brillig calls aren't sufficiently covered, we issue security bug warnings for them.

To illustrate this, the program mentioned in #5425 is also included in test-programs.

Additional Context

This check has been tested on noir-protocol-circuits to measure how it affects compiler performance (employing --benchmark-codegen) and see how many bug occurrences there would be. At the time, the check catches 607 brillig calls there, and the performance hit seems to be negligible. In testing, some false positives have been revealed and addressed, with tests added accordingly.

For some reason, seemingly unrelated to the new check (should happen way before it, and anyway it wouldn't touch a function with no brillig calls) after merging in the latest master the unconditional_recursion test in the inliner fails on CI environment (getting caught with stack overflow before reaching RECURSION_LIMIT) while passing both on mainframe and my dev machine. CI test reruns didn't help. Mitigated this by lowering RECURSION_LIMIT in the inliner for now, please decide if that should stay.

Documentation

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

…check

michaeljklein

LGTM

github-actions · 2024-12-09T18:53:25Z

Compilation Sample

Program	Compilation Time	%
sha256_regression	0m1.465s	0%
regression_4709	0m1.519s	-5%
ram_blowup_regression	0m16.817s	-1%

Co-authored-by: Michael J Klein <[email protected]> Co-authored-by: Akosh Farkash <[email protected]>

…g/noir#6747) chore: Use `NumericType` not `Type` for casts and numeric constants (noir-lang/noir#6769) chore(ci): Extend compiler memory report to external repos (noir-lang/noir#6768) chore(ci): Handle external libraries in compilation timing report (noir-lang/noir#6750) feat(ssa): Implement missing brillig constraints SSA check (noir-lang/noir#6658) fix: Do not merge expressions that contain output witnesses (noir-lang/noir#6757) fix: parser would hand on function type with colon in it (noir-lang/noir#6764) chore(docs): Update branding (noir-lang/noir#6759) feat(cli): Run command on the package closest to the current directory (noir-lang/noir#6752) chore: lock CI to use ubuntu 22.04 (noir-lang/noir#6755) chore: free memory for silenced warnings early (noir-lang/noir#6748) chore(stdlib)!: Remove Schnorr (noir-lang/noir#6749) fix: Improve type error when indexing a variable of unknown type (noir-lang/noir#6744) fix: println("{{}}") was printing "{{}}" instead of "{}" (noir-lang/noir#6745) feat: `std::hint::black_box` function. (noir-lang/noir#6529) feat(ci): Initial compilation report on test_programs (noir-lang/noir#6731) chore: Cleanup unrolling pass (noir-lang/noir#6743) fix: allow empty loop headers (noir-lang/noir#6736) fix: map entry point indexes after all ssa passes (noir-lang/noir#6740) chore: Update url to 2.5.4 (noir-lang/noir#6741) feat: Order attribute execution by their source ordering (noir-lang/noir#6326) feat(test): Check that `nargo::ops::transform_program` is idempotent (noir-lang/noir#6694) feat: Sync from aztec-packages (noir-lang/noir#6730)

chore: Use `NumericType` not `Type` for casts and numeric constants (noir-lang/noir#6769) chore(ci): Extend compiler memory report to external repos (noir-lang/noir#6768) chore(ci): Handle external libraries in compilation timing report (noir-lang/noir#6750) feat(ssa): Implement missing brillig constraints SSA check (noir-lang/noir#6658) fix: Do not merge expressions that contain output witnesses (noir-lang/noir#6757) fix: parser would hand on function type with colon in it (noir-lang/noir#6764) chore(docs): Update branding (noir-lang/noir#6759) feat(cli): Run command on the package closest to the current directory (noir-lang/noir#6752) chore: lock CI to use ubuntu 22.04 (noir-lang/noir#6755) chore: free memory for silenced warnings early (noir-lang/noir#6748) chore(stdlib)!: Remove Schnorr (noir-lang/noir#6749) fix: Improve type error when indexing a variable of unknown type (noir-lang/noir#6744) fix: println("{{}}") was printing "{{}}" instead of "{}" (noir-lang/noir#6745) feat: `std::hint::black_box` function. (noir-lang/noir#6529) feat(ci): Initial compilation report on test_programs (noir-lang/noir#6731) chore: Cleanup unrolling pass (noir-lang/noir#6743) fix: allow empty loop headers (noir-lang/noir#6736) fix: map entry point indexes after all ssa passes (noir-lang/noir#6740) chore: Update url to 2.5.4 (noir-lang/noir#6741) feat: Order attribute execution by their source ordering (noir-lang/noir#6326) feat(test): Check that `nargo::ops::transform_program` is idempotent (noir-lang/noir#6694) feat: Sync from aztec-packages (noir-lang/noir#6730)

) chore: Try replace callstack with a linked list (noir-lang/noir#6747) chore: Use `NumericType` not `Type` for casts and numeric constants (noir-lang/noir#6769) chore(ci): Extend compiler memory report to external repos (noir-lang/noir#6768) chore(ci): Handle external libraries in compilation timing report (noir-lang/noir#6750) feat(ssa): Implement missing brillig constraints SSA check (noir-lang/noir#6658) fix: Do not merge expressions that contain output witnesses (noir-lang/noir#6757) fix: parser would hand on function type with colon in it (noir-lang/noir#6764) chore(docs): Update branding (noir-lang/noir#6759) feat(cli): Run command on the package closest to the current directory (noir-lang/noir#6752) chore: lock CI to use ubuntu 22.04 (noir-lang/noir#6755) chore: free memory for silenced warnings early (noir-lang/noir#6748) chore(stdlib)!: Remove Schnorr (noir-lang/noir#6749) fix: Improve type error when indexing a variable of unknown type (noir-lang/noir#6744) fix: println("{{}}") was printing "{{}}" instead of "{}" (noir-lang/noir#6745) feat: `std::hint::black_box` function. (noir-lang/noir#6529) feat(ci): Initial compilation report on test_programs (noir-lang/noir#6731) chore: Cleanup unrolling pass (noir-lang/noir#6743) fix: allow empty loop headers (noir-lang/noir#6736) fix: map entry point indexes after all ssa passes (noir-lang/noir#6740) chore: Update url to 2.5.4 (noir-lang/noir#6741) feat: Order attribute execution by their source ordering (noir-lang/noir#6326) feat(test): Check that `nargo::ops::transform_program` is idempotent (noir-lang/noir#6694) feat: Sync from aztec-packages (noir-lang/noir#6730)

chore: Try replace callstack with a linked list (noir-lang/noir#6747) chore: Use `NumericType` not `Type` for casts and numeric constants (noir-lang/noir#6769) chore(ci): Extend compiler memory report to external repos (noir-lang/noir#6768) chore(ci): Handle external libraries in compilation timing report (noir-lang/noir#6750) feat(ssa): Implement missing brillig constraints SSA check (noir-lang/noir#6658) fix: Do not merge expressions that contain output witnesses (noir-lang/noir#6757) fix: parser would hand on function type with colon in it (noir-lang/noir#6764) chore(docs): Update branding (noir-lang/noir#6759) feat(cli): Run command on the package closest to the current directory (noir-lang/noir#6752) chore: lock CI to use ubuntu 22.04 (noir-lang/noir#6755) chore: free memory for silenced warnings early (noir-lang/noir#6748) chore(stdlib)!: Remove Schnorr (noir-lang/noir#6749) fix: Improve type error when indexing a variable of unknown type (noir-lang/noir#6744) fix: println("{{}}") was printing "{{}}" instead of "{}" (noir-lang/noir#6745) feat: `std::hint::black_box` function. (noir-lang/noir#6529) feat(ci): Initial compilation report on test_programs (noir-lang/noir#6731) chore: Cleanup unrolling pass (noir-lang/noir#6743) fix: allow empty loop headers (noir-lang/noir#6736) fix: map entry point indexes after all ssa passes (noir-lang/noir#6740) chore: Update url to 2.5.4 (noir-lang/noir#6741) feat: Order attribute execution by their source ordering (noir-lang/noir#6326) feat(test): Check that `nargo::ops::transform_program` is idempotent (noir-lang/noir#6694) feat: Sync from aztec-packages (noir-lang/noir#6730)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE feat: several `nargo test` improvements (noir-lang/noir#6728) chore: Try replace callstack with a linked list (noir-lang/noir#6747) chore: Use `NumericType` not `Type` for casts and numeric constants (noir-lang/noir#6769) chore(ci): Extend compiler memory report to external repos (noir-lang/noir#6768) chore(ci): Handle external libraries in compilation timing report (noir-lang/noir#6750) feat(ssa): Implement missing brillig constraints SSA check (noir-lang/noir#6658) fix: Do not merge expressions that contain output witnesses (noir-lang/noir#6757) fix: parser would hand on function type with colon in it (noir-lang/noir#6764) chore(docs): Update branding (noir-lang/noir#6759) feat(cli): Run command on the package closest to the current directory (noir-lang/noir#6752) chore: lock CI to use ubuntu 22.04 (noir-lang/noir#6755) chore: free memory for silenced warnings early (noir-lang/noir#6748) chore(stdlib)!: Remove Schnorr (noir-lang/noir#6749) fix: Improve type error when indexing a variable of unknown type (noir-lang/noir#6744) fix: println("{{}}") was printing "{{}}" instead of "{}" (noir-lang/noir#6745) feat: `std::hint::black_box` function. (noir-lang/noir#6529) feat(ci): Initial compilation report on test_programs (noir-lang/noir#6731) chore: Cleanup unrolling pass (noir-lang/noir#6743) fix: allow empty loop headers (noir-lang/noir#6736) fix: map entry point indexes after all ssa passes (noir-lang/noir#6740) chore: Update url to 2.5.4 (noir-lang/noir#6741) feat: Order attribute execution by their source ordering (noir-lang/noir#6326) feat(test): Check that `nargo::ops::transform_program` is idempotent (noir-lang/noir#6694) feat: Sync from aztec-packages (noir-lang/noir#6730) END_COMMIT_OVERRIDE --------- Co-authored-by: Tom French <[email protected]> Co-authored-by: thunkar <[email protected]> Co-authored-by: maramihali <[email protected]> Co-authored-by: TomAFrench <[email protected]> Co-authored-by: aakoshh <[email protected]>

🤖 I have created a release *beep* *boop* --- <details><summary>aztec-package: 0.67.0</summary> ## [0.67.0](aztec-package-v0.66.0...aztec-package-v0.67.0) (2024-12-13) ### Features * Deploy faucet ([#10580](#10580)) ([09e95a1](09e95a1)) * Expose P2P service API and clean up logs ([#10552](#10552)) ([98cea58](98cea58)), closes [#10299](#10299) * PXE in the browser ([#10353](#10353)) ([676f673](676f673)) * PXE sync on demand ([#10613](#10613)) ([b2f1159](b2f1159)) ### Bug Fixes * Do not load pino-pretty in production bundles ([#10578](#10578)) ([e515e6e](e515e6e)) * Tweaking Fr and Fq fromString functionality to distinguish number-only strings ([#10529](#10529)) ([736fce1](736fce1)) ### Miscellaneous * Bump jest default test timeout to 30s ([#10550](#10550)) ([841bf48](841bf48)) * Rename logger modules ([#10404](#10404)) ([7441767](7441767)), closes [#10125](#10125) </details> <details><summary>barretenberg.js: 0.67.0</summary> ## [0.67.0](barretenberg.js-v0.66.0...barretenberg.js-v0.67.0) (2024-12-13) ### Features * CIVC browser proveThenVerify ([#10431](#10431)) ([8c064d4](8c064d4)) * Keccak honk proving in bb.js ([#10489](#10489)) ([e0d7431](e0d7431)) ### Bug Fixes * Bump hard coded SRS size for wasm from 2^19 to 2^10 ([#10596](#10596)) ([a37f82d](a37f82d)) </details> <details><summary>aztec-packages: 0.67.0</summary> ## [0.67.0](aztec-packages-v0.66.0...aztec-packages-v0.67.0) (2024-12-13) ### ⚠ BREAKING CHANGES * **stdlib:** Remove Schnorr (noir-lang/noir#6749) * lower public tx gas limit to 6M ([#10635](#10635)) * l2 gas maximum is per-TX-public-portion. AVM startup gas is now 20k. ([#10214](#10214)) * rm outgoing logs ([#10486](#10486)) * rename Header to BlockHeader ([#10372](#10372)) * several format string fixes and improvements (noir-lang/noir#6703) ### Features * `std::hint::black_box` function. (noir-lang/noir#6529) ([3166529](3166529)) * Add rollup circuit sample inputs ([#10608](#10608)) ([775b459](775b459)) * Add verify proof calls to private kernels ([#10533](#10533)) ([ce0eee0](ce0eee0)) * Adding fuzzer for ultra bigfield and relaxing ultra circuit checker ([#10433](#10433)) ([da4c47c](da4c47c)) * Allow making range queries to prometheus in tests ([f9810cc](f9810cc)) * Allow metrics to be instantly flushed ([f9810cc](f9810cc)) * AVM inserts fee write on txs with public calls ([#10394](#10394)) ([98ba747](98ba747)) * **ci:** Initial compilation report on test_programs (noir-lang/noir#6731) ([3166529](3166529)) * CIVC browser proveThenVerify ([#10431](#10431)) ([8c064d4](8c064d4)) * Cli wallet improvements ([#10425](#10425)) ([cc8bd80](cc8bd80)) * **cli:** Run command on the package closest to the current directory (noir-lang/noir#6752) ([3166529](3166529)) * DB Metrics now use labels for easier querying ([#10572](#10572)) ([adadfa5](adadfa5)) * Deploy a network using master each night night ([#10536](#10536)) ([015ec0e](015ec0e)), closes [#10474](#10474) [#10473](#10473) * Deploy faucet ([#10580](#10580)) ([09e95a1](09e95a1)) * Do not make unique revertible note hashes in the private kernels ([#10524](#10524)) ([d327da1](d327da1)) * Emulating blocks and correct (non-partial) note discovery in txe ([#10356](#10356)) ([6f209fb](6f209fb)) * Expose P2P service API and clean up logs ([#10552](#10552)) ([98cea58](98cea58)), closes [#10299](#10299) * GETCONTRACTINSTANCE and bytecode retrieval perform nullifier membership checks ([#10445](#10445)) ([9301253](9301253)), closes [#10377](#10377) [#10379](#10379) * Handle nested calls in witgen ([#10384](#10384)) ([1e21f31](1e21f31)) * Keccak honk proving in bb.js ([#10489](#10489)) ([e0d7431](e0d7431)) * Metrics via terraform ([#10594](#10594)) ([e21069d](e21069d)), closes [#10191](#10191) [#10439](#10439) * Modify HonkRecursionConstraint to handle IPA claims ([#10469](#10469)) ([a204d1b](a204d1b)) * Order attribute execution by their source ordering (noir-lang/noir#6326) ([3166529](3166529)) * Persistence in helm chart for validator and boot node ([#10543](#10543)) ([f9810cc](f9810cc)) * Prover-client exec timing analysis scripts. ([82434a2](82434a2)) * PXE in the browser ([#10353](#10353)) ([676f673](676f673)) * PXE sync on demand ([#10613](#10613)) ([b2f1159](b2f1159)) * Remove auto verify mode from ClientIVC ([#10599](#10599)) ([b1d8b97](b1d8b97)) * Rename Header to BlockHeader ([#10372](#10372)) ([0803964](0803964)) * Rm outgoing logs ([#10486](#10486)) ([c28beec](c28beec)) * Sayonara old hints ([#10547](#10547)) ([dede16e](dede16e)) * Several `nargo test` improvements (noir-lang/noir#6728) ([3166529](3166529)) * Several Updates in SMT verification module (part 1) ([#10437](#10437)) ([0c37672](0c37672)) * **ssa:** Implement missing brillig constraints SSA check (noir-lang/noir#6658) ([3166529](3166529)) * Sync from aztec-packages (noir-lang/noir#6730) ([3166529](3166529)) * **test:** Check that `nargo::ops::transform_program` is idempotent (noir-lang/noir#6694) ([3166529](3166529)) * Unified create circuit from acir ([#10440](#10440)) ([a4dfe13](a4dfe13)) * Update and generate test Prover.tomls for protocol circuits ([#10659](#10659)) ([eb5f18a](eb5f18a)) ### Bug Fixes * [#10473](#10473) ([015ec0e](015ec0e)) * [#10474](#10474) ([015ec0e](015ec0e)) * Allow empty loop headers (noir-lang/noir#6736) ([3166529](3166529)) * Always respect aztec image pull policy ([#10617](#10617)) ([e7686f1](e7686f1)) * Attempt to fix flake in e2e cross chain messaging test ([#10634](#10634)) ([a69502c](a69502c)) * Bad merge on boxes ([#10579](#10579)) ([9b26651](9b26651)) * Boxes webpack config ([#10548](#10548)) ([49f9418](49f9418)) * Bump hard coded SRS size for wasm from 2^19 to 2^10 ([#10596](#10596)) ([a37f82d](a37f82d)) * Bump timeout for failing data store tests ([#10639](#10639)) ([c75fee0](c75fee0)) * Correct size in bytes of a complete address ([#10574](#10574)) ([e72b988](e72b988)) * Destroy old masternet if we can ([#10584](#10584)) ([679684d](679684d)) * Do not attempt proof quote on empty epoch ([#10557](#10557)) ([39d3bc2](39d3bc2)) * Do not load pino-pretty in production bundles ([#10578](#10578)) ([e515e6e](e515e6e)) * Do not merge expressions that contain output witnesses (noir-lang/noir#6757) ([3166529](3166529)) * Ensure LMDB store metrics have hard coded descriptions ([#10642](#10642)) ([043e2c2](043e2c2)) * Formatting master ([#10583](#10583)) ([79e49c9](79e49c9)) * Git dependency trailing slash (noir-lang/noir#6725) ([f4ed66b](f4ed66b)) * Improve type error when indexing a variable of unknown type (noir-lang/noir#6744) ([3166529](3166529)) * Link in README.md ([#10471](#10471)) ([fca9600](fca9600)) * Log level not honored with multi transport ([#10643](#10643)) ([e1e5864](e1e5864)) * Map entry point indexes after all ssa passes (noir-lang/noir#6740) ([3166529](3166529)) * Memory leak in the broker ([#10567](#10567)) ([ecc037f](ecc037f)) * Mispelled aztec ([#10491](#10491)) ([866a5f7](866a5f7)) * Parser would hand on function type with colon in it (noir-lang/noir#6764) ([3166529](3166529)) * Pass salt to deploy-l1-contracts.sh ([#10586](#10586)) ([d6be2c8](d6be2c8)) * Pod anti affinity spans all namespaces ([#10475](#10475)) ([2d4dc3d](2d4dc3d)) * Print ssa blocks without recursion (noir-lang/noir#6715) ([f4ed66b](f4ed66b)) * Println("{{}}") was printing "{{}}" instead of "{}" (noir-lang/noir#6745) ([3166529](3166529)) * Properly trace storage reads to slots never written before in AVM ([#10560](#10560)) ([410c730](410c730)) * Remove auto verify in cbind ivc prove ([#10627](#10627)) ([d773423](d773423)) * Remove otel collector endpoint ([#10604](#10604)) ([276a82c](276a82c)) * Sequencer negative histogram recodings ([#10490](#10490)) ([623f3e2](623f3e2)) * Several format string fixes and improvements (noir-lang/noir#6703) ([f4ed66b](f4ed66b)) * Simulation error enriching ([#10595](#10595)) ([2c36088](2c36088)) * Temporary fix for private kernel tail proving ([#10593](#10593)) ([d194cdf](d194cdf)) * Track published bytecode ([#10636](#10636)) ([cadb4ce](cadb4ce)) * Tweaking Fr and Fq fromString functionality to distinguish number-only strings ([#10529](#10529)) ([736fce1](736fce1)) * Use e2e structure in cbind ([#10585](#10585)) ([985aef1](985aef1)) ### Miscellaneous * Add a few regression tests for [#6674](#6674) (noir-lang/noir#6687) ([f4ed66b](f4ed66b)) * Add script to check for critical libraries supporting a given Noir version (noir-lang/noir#6697) ([f4ed66b](f4ed66b)) * **avm:** Gas constants adjustment based on trace rows accounting ([#10614](#10614)) ([fc729ef](fc729ef)), closes [#10368](#10368) * **avm:** More pilcom compat changes ([#10569](#10569)) ([f18d701](f18d701)) * **avm:** Pilcom compatibility changes ([#10544](#10544)) ([fbc8c0e](fbc8c0e)) * **avm:** Reduce the number of gates for fake AVM recursive verifier ([#10619](#10619)) ([0be44b2](0be44b2)) * **avm:** Remove function selector from AvmExecutionEnvironment ([#10532](#10532)) ([fef5f93](fef5f93)) * Boxes tests cause resource issues ([#10676](#10676)) ([ccf1c78](ccf1c78)) * Bump avm tree test timeout ([323e2eb](323e2eb)) * Bump exp1 config to 48 validators ([#10577](#10577)) ([0379718](0379718)) * Bump jest default test timeout to 30s ([#10550](#10550)) ([841bf48](841bf48)) * Bump mocha timeout ([#10571](#10571)) ([35e525f](35e525f)) * Bump proven timeout ([#10680](#10680)) ([3f5cf6c](3f5cf6c)) * Bump prover agents ([#10626](#10626)) ([64eea72](64eea72)) * **ci:** Extend compiler memory report to external repos (noir-lang/noir#6768) ([3166529](3166529)) * **ci:** Handle external libraries in compilation timing report (noir-lang/noir#6750) ([3166529](3166529)) * **ci:** Prune launch templates job ([#10561](#10561)) ([d6e4f4c](d6e4f4c)) * **ci:** Reenable `rerun-check` job ([#10653](#10653)) ([b2c4f48](b2c4f48)) * Cleanup unrolling pass (noir-lang/noir#6743) ([3166529](3166529)) * Disable broken test ([#10663](#10663)) ([0771260](0771260)) * Disable ivc integration yarn tests ([#10625](#10625)) ([7c50107](7c50107)) * **docs:** Update branding (noir-lang/noir#6759) ([3166529](3166529)) * Documenting convenient redirect to the spartan creator ([#10565](#10565)) ([b94b8ee](b94b8ee)) * Enable nightly tests ([#10542](#10542)) ([4fa068c](4fa068c)) * Faucet LB if public, proving devnet ([#10665](#10665)) ([996d921](996d921)) * Fix build issue from bad merge ([85c0676](85c0676)) * Fix migration notes ([#10656](#10656)) ([333d6ce](333d6ce)) * Fix public keys deserialization ([#10647](#10647)) ([12473c8](12473c8)) * Flush archiver metrics on startup ([f9810cc](f9810cc)) * Free memory for silenced warnings early (noir-lang/noir#6748) ([3166529](3166529)) * Give validators/boot-nodes 100Gi in network configs ([f9810cc](f9810cc)) * Handle errors in e2e teardown to fix e2e token ([#10590](#10590)) ([5d4cdc1](5d4cdc1)) * Increase test timeout to reduce flakes ([#10641](#10641)) ([4ade2ad](4ade2ad)) * Inject k8s pod name and uid ([#10633](#10633)) ([eb472ff](eb472ff)) * L2 gas maximum is per-TX-public-portion. AVM startup gas is now 20k. ([#10214](#10214)) ([1365401](1365401)) * Load balancers for the boot node, longer epochs ([#10632](#10632)) ([001bbb1](001bbb1)) * Lock CI to use ubuntu 22.04 (noir-lang/noir#6755) ([3166529](3166529)) * Log when validator enters commitee ([#10615](#10615)) ([7746a39](7746a39)), closes [#10337](#10337) * Lower public tx gas limit to 6M ([#10635](#10635)) ([9836036](9836036)) * Merge queue CI ([#10629](#10629)) ([835e6fd](835e6fd)) * More bots for exp1 ([#10671](#10671)) ([0ba2425](0ba2425)) * More logs cleanup ([#10630](#10630)) ([00c629c](00c629c)) * Move some nr utils around ([#10553](#10553)) ([d132f83](d132f83)) * Moving stuff from the aztec sequencer node guide into this README ([#10570](#10570)) ([93b8b1b](93b8b1b)) * Optimise grand product computation round based on active ranges ([#10460](#10460)) ([7fa8f84](7fa8f84)) * Optimise older opcodes in reverse order (noir-lang/noir#6476) ([f4ed66b](f4ed66b)) * Redo typo PR by Madmaxs2 (noir-lang/noir#6721) ([f4ed66b](f4ed66b)) * Reduce bb_prover_full_rollup to a single block epoch test ([#10679](#10679)) ([0c2a4d9](0c2a4d9)) * Remove Proxy from json rpc client ([#10554](#10554)) ([93b1c45](93b1c45)) * Remove warnings from protocol circuits ([#10556](#10556)) ([e065e05](e065e05)) * Rename logger modules ([#10404](#10404)) ([7441767](7441767)), closes [#10125](#10125) * Rename pxe script generate-package-info to generate ([#10534](#10534)) ([ead9c0b](ead9c0b)) * Replace relative paths to noir-protocol-circuits ([acfd5df](acfd5df)) * Replace relative paths to noir-protocol-circuits ([6c0533f](6c0533f)) * Replace relative paths to noir-protocol-circuits ([a245b95](a245b95)) * Replace relative paths to noir-protocol-circuits ([153c720](153c720)) * Replace relative paths to noir-protocol-circuits ([a080436](a080436)) * Replace relative paths to noir-protocol-circuits ([8419f5a](8419f5a)) * Secret derivation funcs naming cleanup ([#10637](#10637)) ([5c50711](5c50711)) * Simplify MSM with constant folding (noir-lang/noir#6650) ([f4ed66b](f4ed66b)) * **stdlib:** Remove Schnorr (noir-lang/noir#6749) ([3166529](3166529)) * Try replace callstack with a linked list (noir-lang/noir#6747) ([3166529](3166529)) * Tweak validator logs ([#10597](#10597)) ([9eaa527](9eaa527)) * Unprove devnet ([#10683](#10683)) ([1c92f77](1c92f77)) * Update url to 2.5.4 (noir-lang/noir#6741) ([3166529](3166529)) * Use `NumericType` not `Type` for casts and numeric constants (noir-lang/noir#6769) ([3166529](3166529)) * **val:** Reject proposals not for the current or next slot ([#10450](#10450)) ([27620f5](27620f5)) </details> <details><summary>barretenberg: 0.67.0</summary> ## [0.67.0](barretenberg-v0.66.0...barretenberg-v0.67.0) (2024-12-13) ### ⚠ BREAKING CHANGES * lower public tx gas limit to 6M ([#10635](#10635)) * l2 gas maximum is per-TX-public-portion. AVM startup gas is now 20k. ([#10214](#10214)) * rename Header to BlockHeader ([#10372](#10372)) ### Features * Add verify proof calls to private kernels ([#10533](#10533)) ([ce0eee0](ce0eee0)) * Adding fuzzer for ultra bigfield and relaxing ultra circuit checker ([#10433](#10433)) ([da4c47c](da4c47c)) * AVM inserts fee write on txs with public calls ([#10394](#10394)) ([98ba747](98ba747)) * CIVC browser proveThenVerify ([#10431](#10431)) ([8c064d4](8c064d4)) * GETCONTRACTINSTANCE and bytecode retrieval perform nullifier membership checks ([#10445](#10445)) ([9301253](9301253)), closes [#10377](#10377) [#10379](#10379) * Handle nested calls in witgen ([#10384](#10384)) ([1e21f31](1e21f31)) * Keccak honk proving in bb.js ([#10489](#10489)) ([e0d7431](e0d7431)) * Modify HonkRecursionConstraint to handle IPA claims ([#10469](#10469)) ([a204d1b](a204d1b)) * Remove auto verify mode from ClientIVC ([#10599](#10599)) ([b1d8b97](b1d8b97)) * Rename Header to BlockHeader ([#10372](#10372)) ([0803964](0803964)) * Sayonara old hints ([#10547](#10547)) ([dede16e](dede16e)) * Several Updates in SMT verification module (part 1) ([#10437](#10437)) ([0c37672](0c37672)) * Unified create circuit from acir ([#10440](#10440)) ([a4dfe13](a4dfe13)) ### Bug Fixes * Remove auto verify in cbind ivc prove ([#10627](#10627)) ([d773423](d773423)) * Use e2e structure in cbind ([#10585](#10585)) ([985aef1](985aef1)) ### Miscellaneous * **avm:** Gas constants adjustment based on trace rows accounting ([#10614](#10614)) ([fc729ef](fc729ef)), closes [#10368](#10368) * **avm:** More pilcom compat changes ([#10569](#10569)) ([f18d701](f18d701)) * **avm:** Pilcom compatibility changes ([#10544](#10544)) ([fbc8c0e](fbc8c0e)) * L2 gas maximum is per-TX-public-portion. AVM startup gas is now 20k. ([#10214](#10214)) ([1365401](1365401)) * Lower public tx gas limit to 6M ([#10635](#10635)) ([9836036](9836036)) * Optimise grand product computation round based on active ranges ([#10460](#10460)) ([7fa8f84](7fa8f84)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).

rkarabut added 30 commits October 30, 2024 17:24

WIP on value id parents

d744b60

Merge remote-tracking branch 'origin/master' into directed-graph-ssa-…

5fbf961

…check

Build the actual dependency graph, record constrains/brilligs

8e711ec

Check for brillig call constrain coverage

1ac3e3f

cargo fmt, clippy

e848be7

Move tracing-test to dev-dependencies

d741525

Collect SSA reports

49b59c6

Merge remote-tracking branch 'origin/master' into directed-graph-ssa-…

d33dc07

…check

Remove instruction catch-all

7e6bf9b

Consider brillig call covered if _all_ the results are constrained

b418169

Rework the 5425 reduced test case

ea84f59

Merge remote-tracking branch 'origin/master' into directed-graph-ssa-…

0a6a613

…check

Add 5425 test into test_programs

835571b

Add missing brillig constrain check into ssa.rs

f3e50ec

Add skip check compiler option

0b1bcf8

nargo fmt test program

93eb194

Add multiple results brillig check, fix ancestor walk

b70a4db

Merge remote-tracking branch 'origin/master' into directed-graph-ssa-…

63b9da9

…check

Clean up

a796e2e

Fix possible parent loops, skip covered brillig calls

1dfb9b2

Optimize

a5b7aa8

Reverse order of checking constrains

c9635f5

WIP

2c42c51

Process more cases

5d7520f

Resolve all value ids

610007d

Restore proper 5425 main

2578958

Don't check brillig arguments intersection if there are none

cf031bb

Clean up

632ae24

Add constant brillig call test, fix comments

29db10a

Add range checked brillig call test

b125bd5

Merge branch 'master' into rk/directed-graph-ssa-check

ea7fbc2

michaeljklein approved these changes Dec 9, 2024

View reviewed changes

Merge branch 'master' into rk/directed-graph-ssa-check

9e76cef

rkarabut enabled auto-merge December 9, 2024 19:26

rkarabut added this pull request to the merge queue Dec 9, 2024

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 9, 2024

TomAFrench added this pull request to the merge queue Dec 9, 2024

TomAFrench removed this pull request from the merge queue due to a manual request Dec 9, 2024

github-merge-queue bot pushed a commit that referenced this pull request Dec 9, 2024

feat(ssa): Implement missing brillig constraints SSA check (#6658)

7495430

Co-authored-by: Michael J Klein <[email protected]> Co-authored-by: Akosh Farkash <[email protected]>

TomAFrench and others added 5 commits December 9, 2024 23:34

Merge branch 'master' into rk/directed-graph-ssa-check

3c20db7

Update instruction set

cd37a3d

Fix build

344342f

Merge branch 'master' into rk/directed-graph-ssa-check

4034a1d

Merge branch 'master' into rk/directed-graph-ssa-check

329a131

TomAFrench added this pull request to the merge queue Dec 11, 2024

Merged via the queue into master with commit c5a4caf Dec 11, 2024
51 of 52 checks passed

TomAFrench deleted the rk/directed-graph-ssa-check branch December 11, 2024 11:17

noirwhal mentioned this pull request Dec 11, 2024

chore: Release Noir(1.0.0-beta.1) #6622

Open

AztecBot mentioned this pull request Dec 11, 2024

feat: Sync from noir AztecProtocol/aztec-packages#10483

Merged

AztecBot mentioned this pull request Dec 12, 2024

chore(master): Release 0.67.0 AztecProtocol/aztec-packages#10472

Merged

vezenovm mentioned this pull request Dec 12, 2024

Improved optimization configuration and defaults #6799

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ssa): Implement missing brillig constraints SSA check #6658

feat(ssa): Implement missing brillig constraints SSA check #6658

rkarabut commented Nov 29, 2024 •

edited

Loading

michaeljklein left a comment

github-actions bot commented Dec 9, 2024 •

edited

Loading

feat(ssa): Implement missing brillig constraints SSA check #6658

feat(ssa): Implement missing brillig constraints SSA check #6658

Conversation

rkarabut commented Nov 29, 2024 • edited Loading

Description

Problem

Summary

Additional Context

Documentation

PR Checklist

michaeljklein left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 9, 2024 • edited Loading

Compilation Sample

rkarabut commented Nov 29, 2024 •

edited

Loading

github-actions bot commented Dec 9, 2024 •

edited

Loading