feat: Allow specifying whether the Brillig diff is bytecode size in bytes or opcode count #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Sep 25, 2024
This updates the commit to the noir-gates-diff which does not post a markdown file when there are no changes to the public function sizes. Right now, every PR will post the following snippet: <img width="917" alt="Screenshot 2024-09-25 at 12 25 14 PM" src="https://github.com/user-attachments/assets/83bfb6cc-fece-4ffe-98e4-4bb2bd272155"> Now when there are no changes in public function sizes the snippet will not post. Commit referenced comes from this PR (noir-lang/noir-gates-diff#6).
Rumata888
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Sep 27, 2024
This updates the commit to the noir-gates-diff which does not post a markdown file when there are no changes to the public function sizes. Right now, every PR will post the following snippet: <img width="917" alt="Screenshot 2024-09-25 at 12 25 14 PM" src="https://github.com/user-attachments/assets/83bfb6cc-fece-4ffe-98e4-4bb2bd272155"> Now when there are no changes in public function sizes the snippet will not post. Commit referenced comes from this PR (noir-lang/noir-gates-diff#6).
Rumata888
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Sep 27, 2024
This updates the commit to the noir-gates-diff which does not post a markdown file when there are no changes to the public function sizes. Right now, every PR will post the following snippet: <img width="917" alt="Screenshot 2024-09-25 at 12 25 14 PM" src="https://github.com/user-attachments/assets/83bfb6cc-fece-4ffe-98e4-4bb2bd272155"> Now when there are no changes in public function sizes the snippet will not post. Commit referenced comes from this PR (noir-lang/noir-gates-diff#6).
Rumata888
pushed a commit
to AztecProtocol/aztec-packages
that referenced
this pull request
Sep 27, 2024
This updates the commit to the noir-gates-diff which does not post a markdown file when there are no changes to the public function sizes. Right now, every PR will post the following snippet: <img width="917" alt="Screenshot 2024-09-25 at 12 25 14 PM" src="https://github.com/user-attachments/assets/83bfb6cc-fece-4ffe-98e4-4bb2bd272155"> Now when there are no changes in public function sizes the snippet will not post. Commit referenced comes from this PR (noir-lang/noir-gates-diff#6).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.