Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Brillig opcode diff report for programs #5

Merged
merged 7 commits into from
Aug 19, 2024

Conversation

vezenovm
Copy link
Contributor

@vezenovm vezenovm commented Aug 16, 2024

Description

Problem*

Resolves

Summary*

This PR simply adds similar handling for Brillig functions as already exists for normal ACIR circuits. The "unconstrained_functions" field in the info report produced by nargo info is now handled. Tests have been updated to account for this extra field.

Additional Context

  • This PR only handles Noir compiled with --force-brillig. This was made as the goal is to profile Brillig bytecode compilation optimizations in general, not enabling developers to look at opcode sizes of individual functions like for circuits. Either way, support for multiple functions in a report needs to be added for ACIR as well. I felt this can come in a follow-up.
  • Unconstrained functions in contracts have not been updated in this PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@vezenovm vezenovm changed the title feat: Brillig opcode diff report feat: Brillig opcode diff report for programs Aug 16, 2024
dist/index.js Outdated Show resolved Hide resolved
src/index.ts Outdated Show resolved Hide resolved
@TomAFrench TomAFrench merged commit 3fb8440 into main Aug 19, 2024
5 checks passed
@TomAFrench TomAFrench deleted the mv/brillig-diff-report branch August 19, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants