Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #70

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #70

wants to merge 1 commit into from

Conversation

brunny-eth
Copy link
Contributor

couldn't find zkemail in awesome-noir, added it

Description

Problem*

Resolves

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

couldn't find zkemail in awesome-noir, added it
@@ -231,7 +232,8 @@ A curated list of projects powered by Noir.
- [ZCaptcha](https://github.com/signorecello/zcaptcha) - A ZK version of Captcha
- [ZKPic](https://github.com/0xrishabh/zkPic) - generate zero knowledge proofs for image edits
- [Safecat](https://neimanslab.org/2024-02-19/safecat.html) - a simple CLI tool to generate, sign, and verify digital signatures using EdDSA Baby Jubjub Elliptic Curve signatures and a Poseidon hash function

- [ZKEmail](https://github.com/zkemail/zkemail.nr) - a ZK Email version written in Noir. It is extremely performant on the client side, being ~2x faster on small proofs and ~5-10x speedups on the larger proofs, versus the Circom implementation of ZK Email.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Recommend listing it under "Miscellaneous", instead of "Signatures"
  • Curious where are the speed comparisons with Circom sourced?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • its under Authentication, not signatures. Authentication doesn't seem appropriate?
  • speed comparisons come from zkEmail org-wide github repo; https://github.com/zkemail, search 'Noir'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants