-
-
Notifications
You must be signed in to change notification settings - Fork 17
feat(types-is-native-error): introduce #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
brunocroh
wants to merge
8
commits into
nodejs:main
Choose a base branch
from
brunocroh:feat/types-is-native-error
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+419
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c288f36
to
ddce49b
Compare
AugustinMauroy
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT with rebase
ddce49b
to
d519ac2
Compare
Co-authored-by: Augustin Mauroy <[email protected]>
AugustinMauroy
approved these changes
Aug 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is green.
avivkeller
reviewed
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #113
This PR depends on PR #151 being merged first.
Overview
This PR introduces a new TypeScript transformation that automatically migrates deprecated
util.types.isNativeError
usage to the modernError.isError
API.Additional work
This implements one additional case for
utils/src/ast-grep/remove-binding.ts
. Previously, it failed to remove deep named imports, so I fixed this behaviour and added a new test to prevent regressionPrevious behaviour:
input
result
New behaviour:
input
result