Skip to content

Conversation

AugustinMauroy
Copy link
Member

@AugustinMauroy AugustinMauroy commented Jul 29, 2025

Description

Add new codemod to handle this depreciation

Related issue

Close #121

@AugustinMauroy AugustinMauroy marked this pull request as draft July 30, 2025 09:15
@AugustinMauroy AugustinMauroy marked this pull request as ready for review July 31, 2025 09:22
@AugustinMauroy AugustinMauroy requested a review from a team July 31, 2025 09:22
@AugustinMauroy AugustinMauroy force-pushed the feat(`repl-builtinModules`) branch from 44e207e to f8fcfb0 Compare July 31, 2025 09:43
@brunocroh
Copy link
Member

brunocroh commented Jul 31, 2025

I think this recipe can be a great use case for the new utility function when it is ready to use, what do you think? #151

@AugustinMauroy
Copy link
Member Author

I think this recipe can be a great use case for the new utility function when it is ready to use, what do you think? #151

YESS but need to wait approval on the pr

@AugustinMauroy AugustinMauroy force-pushed the feat(`repl-builtinModules`) branch from 803ec84 to 827fcc9 Compare August 2, 2025 21:07
@AugustinMauroy AugustinMauroy force-pushed the feat(`repl-builtinModules`) branch from 827fcc9 to c38bfc1 Compare August 11, 2025 09:20
@AugustinMauroy AugustinMauroy force-pushed the feat(`repl-builtinModules`) branch from 1518b45 to 5ae19aa Compare August 11, 2025 10:21
@AugustinMauroy AugustinMauroy force-pushed the feat(`repl-builtinModules`) branch from 5ae19aa to e3497b4 Compare August 11, 2025 11:03
Copy link
Member

@avivkeller avivkeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Started a review.

There's a lot of places where you check both properties, those can probably be refactored to common helpers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: handle repl.builtinModules depreciation
3 participants