fix(dns): preserve header shape for [string,string][] and ensure Host #4498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
reviewed
Sep 1, 2025
| @@ -5,6 +5,43 @@ const DecoratorHandler = require('../handler/decorator-handler') | |||
| const { InvalidArgumentError, InformationalError } = require('../core/errors') | |||
| const maxInt = Math.pow(2, 31) - 1 | |||
|
|
|||
| function addHostHeader (headers, host) { | |||
There was a problem hiding this comment.
Hmm, you don't need to parse the headers by yourself, this is done by undici automatically, we just need to standardise the way that these are forward to undici.
If Array, push host to the headers array, if an object, attach host as a new property
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
#4444
Rationale
Preserve header shape and correct Host after DNS resolution to avoid routing issues/header corruption
Changes
Added
addHostHeaderto dns interceptor and parameterized tests for different header types.Bug Fixes
Fixed DNS interceptor turning [string, string][]/iterables into numeric-key headers
Status