fix: avoid setup global dispatcher in advance #4357
+22
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himself65
force-pushed
the
himself65/2025/07/22/global
branch
4 times, most recently
from
18a7803 to
db91409
Compare
|
CI doesn't seem happy |
|
Yeah I see, trying to figure out |
himself65
force-pushed
the
himself65/2025/07/22/global
branch
from
2f72fee to
ac9a14b
Compare
himself65
force-pushed
the
himself65/2025/07/22/global
branch
from
ac9a14b to
84533e6
Compare
|
@mcollina updated the code |
metcoder95
approved these changes
Aug 10, 2025
gurgunday
approved these changes
Aug 10, 2025
mcollina
requested changes
Aug 11, 2025
| }, | ||
| set (agent) { | ||
| setGlobalDispatcher(agent) | ||
| }, |
There was a problem hiding this comment.
Unfortunately this implementation is not equivalent. After this change, whoever is reading the dispatcher would invoke a function, which would generate a slight overhead. The solution is on first access to remove all this getter business.
| throw new InvalidArgumentError('Argument agent must implement Agent') | ||
| } | ||
| currentDispatcher = agent | ||
| } |
There was a problem hiding this comment.
I'm relatively certain this function is already available somewhere
|
Would it make more sense for undici to always overwrite the global dispatcher (if it's not from undici already)? Importing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
lazy setup dispatcher so that lazyLoadUndici in node.js core module won't affect the
globalThisFeatures
Bug Fixes
Fixes: nodejs/node#59012
Breaking Changes and Deprecations
Status