Set pipelining to 4 by default #3846
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matteo Collina <[email protected]>
mcollina
added
the
semver-major
|
This seemed a good idea, but it breaks |
Signed-off-by: Matteo Collina <[email protected]>
ronag
approved these changes
Nov 19, 2024
How? Fetch should always set blocking true. |
The wpts expects no pipelining for it. I don't really understand if it's a strong requirement, or not. |
Signed-off-by: Matteo Collina <[email protected]>
ronag
approved these changes
Nov 19, 2024
metcoder95
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we landed #3771, we could easily set a
pipeliningvalue greater than zero, because all request will queue up until headers of the previous response have been received.