chore: enable pipefail for snapcraft.yaml.sh #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trap empty `NODE_VERSION`, e.g. if fetching `index.tab` fails. Refs: #38
richardlau
commented
May 6, 2022
| @@ -36,7 +36,7 @@ done | |||
| # not a release? | |||
| if [ -z ${NODE_DISTTYPE+x} ]; then | |||
| # nightly | |||
| NODE_VERSION="$(curl -sL https://nodejs.org/download/nightly/index.tab | awk '/^v[1-9].*[^a-z0-9]src[^a-z0-9]/ { print substr($1, 2); exit }')" | |||
| NODE_VERSION="$(curl -sL --show-error --fail https://nodejs.org/download/nightly/index.tab | awk 'BEGIN { found = 0 } /^v[1-9].*[^a-z0-9]src[^a-z0-9]/ && !found { found = 1; print substr($1, 2) }')" | |||
There was a problem hiding this comment.
The changes to the awk script are to make awk read all of the input. Previously the script contained an early exit which causes curl to exit with exit code 23 as the pipe is closed by awk before curl has finished writing to it. This was masked before by the -s (silent) curl option but surfaced when pipefail was enabled.
e.g. https://github.com/nodejs/snap/runs/6322739611?check_suite_focus=true
|
btw, when making changes to snapcraft.yml.sh, you'll need to merge and then cherry-pick that commit to the head of each of the active branches that are in use by cron and push back to this repo; otherwise it'll only be active for the |
richardlau
added a commit
that referenced
this pull request
May 7, 2022
Trap empty `NODE_VERSION`, e.g. if fetching `index.tab` fails. Refs: #38
richardlau
added a commit
that referenced
this pull request
May 7, 2022
Trap empty `NODE_VERSION`, e.g. if fetching `index.tab` fails. Refs: #38
richardlau
added a commit
that referenced
this pull request
May 7, 2022
Trap empty `NODE_VERSION`, e.g. if fetching `index.tab` fails. Refs: #38
richardlau
added a commit
that referenced
this pull request
May 7, 2022
Trap empty `NODE_VERSION`, e.g. if fetching `index.tab` fails. Refs: #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trap empty
NODE_VERSION, e.g. if fetchingindex.tabfails.Refs: #38