Skip to content

Conversation

avivkeller
Copy link
Member

Fixes #8072

@Copilot Copilot AI review requested due to automatic review settings September 1, 2025 14:02
@avivkeller avivkeller requested a review from a team as a code owner September 1, 2025 14:02
Copy link

vercel bot commented Sep 1, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Sep 1, 2025 2:04pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the translation of "OpenJS Foundation" by ensuring it remains untranslated across all locales. The organization name should be kept as a proper noun in its original English form rather than being translated to local languages.

  • Removed translated versions of "OpenJS Foundation" from all locale files
  • Updated the navigation type system to support both translatable labels and static text
  • Modified the footer component to handle both translatable and non-translatable text

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

File Description
packages/i18n/src/locales/*.json Removed translated "openJSFoundation" entries from Ukrainian, Romanian, Japanese, French, and English locale files
apps/site/types/navigation.ts Updated FooterConfig type to support optional label and text properties
apps/site/navigation.json Changed OpenJS Foundation link from translatable label to static text
apps/site/components/withFooter.tsx Updated footer rendering logic to handle both translatable labels and static text

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Sep 1, 2025

Note

Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project.
We recommend giving a read on our Translation Guidelines.

Thank you!

Copy link

codecov bot commented Sep 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.60%. Comparing base (9f16142) to head (3691d39).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8129      +/-   ##
==========================================
+ Coverage   76.56%   76.60%   +0.04%     
==========================================
  Files         115      115              
  Lines        9595     9595              
  Branches      322      321       -1     
==========================================
+ Hits         7346     7350       +4     
+ Misses       2248     2244       -4     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT !

@mikeesto
Copy link
Member

mikeesto commented Sep 2, 2025

In #8072 it was mentioned that at least in Chinese and Japanese, 'Foundation' would be expected to be translated so I'm not sure this is the answer?

Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocking per resolution of conversation with Open JS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do not translate OpenJS Foundation
4 participants