Skip to content

fix(turbo): add root prettier:fix task to format command #8109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −1
Open

fix(turbo): add root prettier:fix task to format command #8109

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"cloudflare:preview": "turbo cloudflare:preview",
"deploy": "turbo deploy",
"dev": "turbo dev",
"format": "turbo prettier:fix lint:fix",
"format": "turbo //#prettier:fix prettier:fix lint:fix",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"format": "turbo //#prettier:fix prettier:fix lint:fix",
"format": "turbo //#prettier:fix lint:fix",

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't this also be node --run prettier:fix && turbo lint:fix, since we don't even need turbo for prettier?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since rest of the commands were only using turbo-based approach so gave preference to that.

But yeah, we can definitely use direct node.js execution for prettier & turbo for linting. Also then if we don't need turbo for prettier, we should remove the prettier tasks from turbo.json?

"lint": "turbo lint",
"lint:fix": "turbo lint:fix",
"lint:staged": "lint-staged",
Expand Down
3 changes: 3 additions & 0 deletions turbo.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,9 @@
"//#prettier": {
"outputs": [".prettiercache"]
},
"//#prettier:fix": {
"outputs": [".prettiercache"]
},
"build": {
"dependsOn": ["^topo"]
},
Expand Down
Loading