Automated, scheduled crowdin sync #7272
Open
+65
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This comment was marked as resolved.
This comment was marked as resolved.
bmuenzenmeyer
force-pushed
the
crowdin-gh-action
branch
from
7dbeb77
to
3ee0588
Compare
bmuenzenmeyer
force-pushed
the
crowdin-gh-action
branch
from
3ee0588
to
1f17c61
Compare
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Co-authored-by: Copilot <[email protected]> Signed-off-by: Brian Muenzenmeyer <[email protected]>
Unit Test Coverage Report
Unit Test Report
|
github-actions
bot
removed
the
github_actions:pull-request
RedYetiDev
approved these changes
Nov 21, 2024
Comment on lines
+37
to
+38
| # testing only | ||
| dryrun_action: true |
There was a problem hiding this comment.
Suggested change
| # testing only | |
| dryrun_action: true |
This should no longer be a dry run once it lands, right?
There was a problem hiding this comment.
correct - if we are confident it will run okay without - we can remove now. it's sorta an odd chicken and egg problem. a fast follower can pretty easily resolve / debug / refine as needed
bjohansebas
reviewed
Nov 21, 2024
bmuenzenmeyer
commented
Nov 21, 2024
Comment on lines
+39
to
+43
| # do not upload existing translations - this is a one-way operation | ||
| upload_sources: true | ||
| upload_translations: false | ||
| # the rest of this controls how the PR comes in with new translations | ||
| download_translations: true |
There was a problem hiding this comment.
crowdin suggested separating upload and download to two separate workflows, else new sources would have to wait a week
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an automated way to initiate crowdin syncs.
In talking with the crowdin team, this seemed to be the logical next step.
Note that this does not replace our existing workflow, which:
Validation
Related Issues
#7121
Check List
npm run formatto ensure the code follows the style guide.npm run testto check if all tests are passing.npx turbo buildto check if the website builds without errors.