meta: skip lighthouse CI when no vercel preview detected #7266
Conversation
Signed-off-by: Aviv Keller <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
The commit message didn't save 🤔, regardless, the PR title will be used, right? If not, feel free to force push and fix it. |
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.
|
|
| ${{ needs.get-vercel-preview.outputs.url }}/en/about | ||
| ${{ needs.get-vercel-preview.outputs.url }}/en/about/previous-releases | ||
| ${{ needs.get-vercel-preview.outputs.url }}/en/download | ||
| ${{ needs.get-vercel-preview.outputs.url }}/en/blog |
There was a problem hiding this comment.
Shouldn't that be a followup, given that this is specifically for skipping the workflow?
There was a problem hiding this comment.
this list was semi-intelligently designed not to be exhaustive of all pages, but to try to hit the major features
- homepage (global)
- markdown rendering (about)
- previous-releases (the release data / table)
- download (release data / os detection / lots of complexity)
- blog (blog data / rendering)
There was a problem hiding this comment.
Imo we should test the learn section to ensure everything is right. Yeah it's look like about but it's not same eg there are avatars in the learn page
| @@ -27,12 +27,39 @@ permissions: | |||
| pull-requests: write | |||
|
|
|||
| jobs: | |||
| lighthouse-ci: | |||
| get-vercel-preview: | |||
| # We want to skip our lighthouse analysis on Dependabot PRs | |||
There was a problem hiding this comment.
this comment needs to move with the ordering
There was a problem hiding this comment.
What do you mean? It's commenting on the line below (skipping the Dependabot).
| ${{ needs.get-vercel-preview.outputs.url }}/en/about | ||
| ${{ needs.get-vercel-preview.outputs.url }}/en/about/previous-releases | ||
| ${{ needs.get-vercel-preview.outputs.url }}/en/download | ||
| ${{ needs.get-vercel-preview.outputs.url }}/en/blog |
There was a problem hiding this comment.
this list was semi-intelligently designed not to be exhaustive of all pages, but to try to hit the major features
- homepage (global)
- markdown rendering (about)
- previous-releases (the release data / table)
- download (release data / os detection / lots of complexity)
- blog (blog data / rendering)
Description
This changes the Lighthouse CI to skip when a Vercel preview is not detected
Related Issues
#7253