-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
content(blog/events): Dublin collab summit 2024 #7215
base: main
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks for this. I'll try to flesh out my section in the next day or so.
Co-Authored-By: Jacob Smith <[email protected]>
fbcd43b
to
5f7a00f
Compare
Commit cotent -> content |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it :-)
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Augustin Mauroy <[email protected]>
BTW, we use squash and merge for pr so just the title is important 😄 |
<!-- | ||
day 1: https://hackmd.io/-8o2Th28QhuNJwO43fafAw | ||
day 2: https://hackmd.io/V3xtjlcrTIGsemPv8t-tKg | ||
--> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we keep that ? or we will have somewhere on GitHub.
cc @joyeecheung (who write the big part of theses minute meeting)
Joyee's feedback on slack:
and
|
|
||
- **CI Challenges**: Jacob highlighted the biggest issue with the CI system as finding out what is wrong when something goes awry. This can be a frustrating and time-consuming process for collaborators. | ||
- **ncu-ci Command**: Joyee showcased the `ncu-ci` command and the reliability repository, demonstrating tools that can help streamline the CI process and improve collaborator efficiency. | ||
- **Documentation Needs**: mhdawson and Geoffrey emphasized the importance of mentioning the `ncu-ci` command in the bot comment for CI and documenting it better in the collaborator guide. This would ensure that collaborators are aware of the available tools and how to use them effectively. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Throughout the doc, first names are used, why is it different here? (And in a few other places)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I based myself on the minute meeting (split the screen). so I used what was in it/what I had in front of me.
I would also like to echo @joyeecheung's feedback that the average user may not know who the collaborators are, and may not be interested in who-said-what. as mentioned, just saying "we discussed ..." may be better |
We should not name people here IMO, should be anonymous. |
IDK, in the other there are certain name. |
Take the following excerpt from the one you linked:
Note the following:
Comparing this to a snippet of yours:
Note the following:
This could be changed to be parallel with the first format:
|
Bear in mind that there's going to be a lot of rewriting to do with what Joyee has come up with.
As I said in the description of the PR, the idea is to have a family and welcoming feel, which is why I'd like there to be two or three personal notes at the end of the post (not just mine). But may be remove it |
I like the heading hierarchy of the content - it'd be nice if we visually indicated the indentation level. I think H2 and H3 only. Look at content like https://nodejs.org/en/learn/test-runner/mocking for similar needs. |
Description
Writting a blog post to summarize the summit.
The aim is to enable people who are not involved in the project to find out what's going on. And to make this post familiar in the way it is written.
Check List
npm run format
to ensure the code follows the style guide.npm run test
to check if all tests are passing.npx turbo build
to check if the website builds without errors.